Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Commit 95a7a6a

Browse files
committed
Add AuthenticationProperties to AuthenticateResult for failures.
1 parent 44df557 commit 95a7a6a

File tree

1 file changed

+23
-5
lines changed

1 file changed

+23
-5
lines changed

src/Microsoft.AspNetCore.Authentication.Abstractions/AuthenticateResult.cs

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ protected AuthenticateResult() { }
3131
/// <summary>
3232
/// Additional state values for the authentication session.
3333
/// </summary>
34-
public AuthenticationProperties Properties => Ticket?.Properties;
34+
public AuthenticationProperties Properties { get; protected set; }
3535

3636
/// <summary>
3737
/// Holds failure information from the authentication.
@@ -54,7 +54,7 @@ public static AuthenticateResult Success(AuthenticationTicket ticket)
5454
{
5555
throw new ArgumentNullException(nameof(ticket));
5656
}
57-
return new AuthenticateResult() { Ticket = ticket };
57+
return new AuthenticateResult() { Ticket = ticket, Properties = ticket.Properties };
5858
}
5959

6060
/// <summary>
@@ -79,11 +79,29 @@ public static AuthenticateResult Fail(Exception failure)
7979
/// <summary>
8080
/// Indicates that there was a failure during authentication.
8181
/// </summary>
82-
/// <param name="failureMessage">The failure message.</param>
82+
/// <param name="failure">The failure exception.</param>
83+
/// <param name="properties">Additional state values for the authentication session.</param>
8384
/// <returns>The result.</returns>
84-
public static AuthenticateResult Fail(string failureMessage)
85+
public static AuthenticateResult Fail(Exception failure, AuthenticationProperties properties)
8586
{
86-
return new AuthenticateResult() { Failure = new Exception(failureMessage) };
87+
return new AuthenticateResult() { Failure = failure, Properties = properties };
8788
}
89+
90+
/// <summary>
91+
/// Indicates that there was a failure during authentication.
92+
/// </summary>
93+
/// <param name="failureMessage">The failure message.</param>
94+
/// <returns>The result.</returns>
95+
public static AuthenticateResult Fail(string failureMessage)
96+
=> Fail(new Exception(failureMessage));
97+
98+
/// <summary>
99+
/// Indicates that there was a failure during authentication.
100+
/// </summary>
101+
/// <param name="failureMessage">The failure message.</param>
102+
/// <param name="properties">Additional state values for the authentication session.</param>
103+
/// <returns>The result.</returns>
104+
public static AuthenticateResult Fail(string failureMessage, AuthenticationProperties properties)
105+
=> Fail(new Exception(failureMessage), properties);
88106
}
89107
}

0 commit comments

Comments
 (0)