Add string+PathString operator to prevent too much string<->PathString implicit conversion.

Author: Tratcher

src/Microsoft.AspNet.Http.Core/PathString.cs

@@ -215,6 +215,18 @@ public override int GetHashCode()
             return !left.Equals(right, StringComparison.OrdinalIgnoreCase);
         }
 
+        /// <summary>
+        /// </summary>
+        /// <param name="left">The left parameter</param>
+        /// <param name="right">The right parameter</param>
+        /// <returns>The ToString combination of both values</returns>
+        public static string operator +(string left, PathString right)
+        {
+            // This overload exists to prevent the implicit string<->PathString converter from
+            // trying to call the PathString+PathString operator for things that are not path strings.
+            return string.Concat(left, right.ToString());
+        }
+
         /// <summary>
         /// Operator call through to Add
         /// </summary>

test/Microsoft.AspNet.Http.Core.Tests/PathStringTests.cs

@@ -50,5 +50,19 @@ public void AddPathString_HandlesLeadingAndTrailingSlashes(string appString, str
             // Assert
             Assert.Equal(expected, result.Value);
         }
+
+        [Fact]
+        public void ImplicitStringConverters_WorksWithAdd()
+        {
+            var scheme = "http";
+            var host = new HostString("localhost:80");
+            var pathBase = new PathString("/base");
+            var path = new PathString("/path");
+            var query = new QueryString("?query");
+            var fragment = new FragmentString("#frag");
+
+            var result = scheme + "://" + host + pathBase + path + query + fragment;
+            Assert.Equal("http://localhost:80/base/path?query#frag", result);
+        }
     }
 }