Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Commit 6f24508

Browse files
committed
Move remaining feature interfaces into Microsoft.AspNetCore.Http.Features package and namespace
- #590, also related to #561 - move feature interfaces from `Microsoft.AspNetCore.Http` package - move required classes from `Microsoft.AspNetCore.Http.Abstractions` package - move `ISession` and `WebSocketAcceptContext` to `Microsoft.AspNetCore.Http` namespace (#590) nit: remove transient dependencies listed in `Microsoft.AspNetCore.Http.Abstractions`'s `project.json`
1 parent 131db6c commit 6f24508

23 files changed

+25
-27
lines changed

src/Microsoft.AspNetCore.Http.Abstractions/project.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@
2929
},
3030
"netstandard1.3": {
3131
"dependencies": {
32-
"System.ComponentModel": "4.0.1-*",
3332
"System.Globalization.Extensions": "4.0.1-*",
3433
"System.Linq.Expressions": "4.0.11-*",
35-
"System.Net.WebSockets": "4.0.0-*",
3634
"System.Reflection.TypeExtensions": "4.1.0-*",
3735
"System.Runtime.InteropServices": "4.1.0-*"
3836
},

src/Microsoft.AspNetCore.Http.Extensions/SessionExtensions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

44
using System.Text;
5-
using Microsoft.AspNetCore.Http.Features;
65

76
namespace Microsoft.AspNetCore.Http
87
{

src/Microsoft.AspNetCore.Http.Abstractions/IFormCollection.cs renamed to src/Microsoft.AspNetCore.Http.Features/IFormCollection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ public interface IFormCollection : IEnumerable<KeyValuePair<string, StringValues
1818
/// The number of elements contained in the <see cref="T:Microsoft.AspNetCore.Http.IFormCollection" />.
1919
/// </returns>
2020
int Count { get; }
21-
21+
2222
/// <summary>
23-
/// Gets an <see cref="T:System.Collections.Generic.ICollection`1" /> containing the keys of the
23+
/// Gets an <see cref="T:System.Collections.Generic.ICollection`1" /> containing the keys of the
2424
/// <see cref="T:Microsoft.AspNetCore.Http.IFormCollection" />.
2525
/// </summary>
2626
/// <returns>
@@ -79,7 +79,7 @@ public interface IFormCollection : IEnumerable<KeyValuePair<string, StringValues
7979
/// key is null.
8080
/// </exception>
8181
/// <remarks>
82-
/// <see cref="T:Microsoft.AspNetCore.Http.IFormCollection" /> has a different indexer contract than
82+
/// <see cref="T:Microsoft.AspNetCore.Http.IFormCollection" /> has a different indexer contract than
8383
/// <see cref="T:System.Collections.Generic.IDictionary`2" />, as it will return StringValues.Empty for missing entries
8484
/// rather than throwing an Exception.
8585
/// </remarks>

src/Microsoft.AspNetCore.Http/Features/IFormFeature.cs renamed to src/Microsoft.AspNetCore.Http.Features/IFormFeature.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
using System.Threading;
55
using System.Threading.Tasks;
66

7-
namespace Microsoft.AspNetCore.Http.Features.Internal
7+
namespace Microsoft.AspNetCore.Http.Features
88
{
99
public interface IFormFeature
1010
{

src/Microsoft.AspNetCore.Http/Features/IItemsFeature.cs renamed to src/Microsoft.AspNetCore.Http.Features/IItemsFeature.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
using System.Collections.Generic;
55

6-
namespace Microsoft.AspNetCore.Http.Features.Internal
6+
namespace Microsoft.AspNetCore.Http.Features
77
{
88
public interface IItemsFeature
99
{

src/Microsoft.AspNetCore.Http.Abstractions/IQueryCollection.cs renamed to src/Microsoft.AspNetCore.Http.Features/IQueryCollection.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public interface IQueryCollection : IEnumerable<KeyValuePair<string, StringValue
2020
int Count { get; }
2121

2222
/// <summary>
23-
/// Gets an <see cref="T:System.Collections.Generic.ICollection`1" /> containing the keys of the
23+
/// Gets an <see cref="T:System.Collections.Generic.ICollection`1" /> containing the keys of the
2424
/// <see cref="T:Microsoft.AspNetCore.Http.IQueryCollection" />.
2525
/// </summary>
2626
/// <returns>
@@ -73,13 +73,14 @@ public interface IQueryCollection : IEnumerable<KeyValuePair<string, StringValue
7373
/// The key of the value to get.
7474
/// </param>
7575
/// <returns>
76-
/// The element with the specified key, or <see cref="T:Microsoft.Extensions.Primitives.StringValues" />.Empty if the key is not present.
76+
/// The element with the specified key, or <see cref="T:Microsoft.Extensions.Primitives.StringValues" />.
77+
/// Empty if the key is not present.
7778
/// </returns>
7879
/// <exception cref="T:System.ArgumentNullException">
7980
/// key is null.
8081
/// </exception>
8182
/// <remarks>
82-
/// <see cref="T:Microsoft.AspNetCore.Http.IQueryCollection" /> has a different indexer contract than
83+
/// <see cref="T:Microsoft.AspNetCore.Http.IQueryCollection" /> has a different indexer contract than
8384
/// <see cref="T:System.Collections.Generic.IDictionary`2" />, as it will return StringValues.Empty for missing entries
8485
/// rather than throwing an Exception.
8586
/// </remarks>

src/Microsoft.AspNetCore.Http/Features/IQueryFeature.cs renamed to src/Microsoft.AspNetCore.Http.Features/IQueryFeature.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) .NET Foundation. All rights reserved.
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

4-
namespace Microsoft.AspNetCore.Http.Features.Internal
4+
namespace Microsoft.AspNetCore.Http.Features
55
{
66
public interface IQueryFeature
77
{

0 commit comments

Comments
 (0)