More Cleanup.

Author: Tratcher

src/Microsoft.AspNet.FileProviders.Common/Implementation/EnumerableDirectoryContents.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNet.FileProviders
 {
-    public class EnumerableDirectoryContents : IDirectoryContents
+    internal class EnumerableDirectoryContents : IDirectoryContents
     {
         private readonly IEnumerable<IFileInfo> _entries;
 

src/Microsoft.AspNet.FileProviders.Common/Implementation/NoopTrigger.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNet.FileProviders
 {
-    public class NoopTrigger : IExpirationTrigger
+    internal class NoopTrigger : IExpirationTrigger
     {
         public static NoopTrigger Singleton { get; } = new NoopTrigger();
 

src/Microsoft.AspNet.FileProviders.Common/Implementation/NotFoundDirectoryContents.cs

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNet.FileProviders
 {
-    public class NotFoundDirectoryContents : IDirectoryContents
+    internal class NotFoundDirectoryContents : IDirectoryContents
     {
         public NotFoundDirectoryContents()
         {

src/Microsoft.AspNet.FileProviders.Common/Implementation/NotFoundFileInfo.cs

@@ -9,7 +9,7 @@ namespace Microsoft.AspNet.FileProviders
     /// <summary>
     /// Represents a non-existing file.
     /// </summary>
-    public class NotFoundFileInfo : IFileInfo
+    internal class NotFoundFileInfo : IFileInfo
     {
         private readonly string _name;
 
@@ -50,7 +50,7 @@ public string PhysicalPath
 
         public Stream CreateReadStream()
         {
-            throw new InvalidOperationException(string.Format("The file {0} does not exist.", Name));
+            throw new FileNotFoundException(string.Format("The file {0} does not exist.", Name));
         }
     }
 }

src/Microsoft.AspNet.FileProviders.Common/Properties/AssemblyInfo.cs

@@ -1,6 +1,6 @@
 {
     "version": "1.0.0-*",
-    "description": "Implementation of ASP.NET 5 embedded file provider abstractions.",
+    "description": "Implementation of ASP.NET 5 file provider abstractions for embedded resources.",
     "dependencies": {
         "Microsoft.AspNet.FileProviders.Common": { "version": "1.0.0-*", "type": "build" },
         "Microsoft.AspNet.FileProviders.Interfaces": "1.0.0-*"

src/Microsoft.AspNet.FileProviders.Embedded/project.json

@@ -1,6 +1,6 @@
 {
     "version": "1.0.0-*",
-    "description": "Implementation of ASP.NET 5 physical file provider abstractions.",
+    "description": "Implementation of ASP.NET 5 file provider abstractions for physical files.",
     "dependencies": {
         "Microsoft.AspNet.FileProviders.Common": { "version": "1.0.0-*", "type": "build" },
         "Microsoft.AspNet.FileProviders.Interfaces": "1.0.0-*"

src/Microsoft.AspNet.FileProviders.Physical/project.json

@@ -114,9 +114,17 @@ public void Missing_Hidden_And_FilesStartingWithPeriod_ReturnFalse()
 
             var provider = new PhysicalFileProvider(Path.GetTempPath());
 
-            provider.GetFileInfo(Guid.NewGuid().ToString()).Exists.ShouldBe(false);
-            provider.GetFileInfo(hiddenFileName).Exists.ShouldBe(false);
-            provider.GetFileInfo(fileNameStartingWithPeriod).Exists.ShouldBe(false);
+            var file = provider.GetFileInfo(Guid.NewGuid().ToString());
+            file.Exists.ShouldBe(false);
+            Should.Throw<FileNotFoundException>(() => file.CreateReadStream());
+
+            file = provider.GetFileInfo(hiddenFileName);
+            file.Exists.ShouldBe(false);
+            Should.Throw<FileNotFoundException>(() => file.CreateReadStream());
+
+            file = provider.GetFileInfo(fileNameStartingWithPeriod);
+            file.Exists.ShouldBe(false);
+            Should.Throw<FileNotFoundException>(() => file.CreateReadStream());
         }
 
         [Fact]
@@ -143,13 +151,6 @@ public void GetDirectoryContents_FromRootPath_ForEmptyDirectoryName()
             fileInfo.Exists.ShouldBe(true);
         }
 
-        [Fact]
-        public void NotFoundFileInfo_BasicTests()
-        {
-            var info = new NotFoundFileInfo("NotFoundFile.txt");
-            Should.Throw<InvalidOperationException>(() => info.CreateReadStream());
-        }
-
         [Fact]
         public void RelativePathPastRootNotAllowed()
         {