Skip to content

SignalR HubConnectionContext constructors changing #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrennanConroy opened this issue Jun 20, 2019 · 0 comments
Open

SignalR HubConnectionContext constructors changing #369

BrennanConroy opened this issue Jun 20, 2019 · 0 comments
Labels
3.0.0 Announcements related to ASP.NET Core 3.0 Announcement Breaking change Documented The breaking change has been published to the .NET Core docs Migrated

Comments

@BrennanConroy
Copy link
Member

BrennanConroy commented Jun 20, 2019

Prior to 3.0 HubConnectionContext had two constructors:

public HubConnectionContext(ConnectionContext connectionContext, TimeSpan keepAliveInterval, ILoggerFactory loggerFactory);
public HubConnectionContext(ConnectionContext connectionContext, TimeSpan keepAliveInterval, ILoggerFactory loggerFactory, TimeSpan clientTimeoutInterval);

In 3.0 these 2 constructors have been removed and replaced them with a new one:

public HubConnectionContext(ConnectionContext connectionContext, HubConnectionContextOptions contextOptions, ILoggerFactory loggerFactory)

This new constructor makes use of a new options object, so we can expand the features of HubConnectionContext in the future without making more constructors and breaking changes.

Use dotnet/aspnetcore#11431 to discuss this.

This announcement has been migrated to: dotnet/docs#14845

@BrennanConroy BrennanConroy added Announcement Breaking change 3.0.0 Announcements related to ASP.NET Core 3.0 labels Jun 20, 2019
@BrennanConroy BrennanConroy added this to the 3.0.0 milestone Jun 20, 2019
@aspnet aspnet locked and limited conversation to collaborators Jun 20, 2019
@analogrelay analogrelay modified the milestones: 3.0.0, 3.0.0-preview7 Jun 27, 2019
@jkotalik jkotalik removed their assignment Oct 1, 2019
@scottaddie scottaddie added the Documented The breaking change has been published to the .NET Core docs label Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.0.0 Announcements related to ASP.NET Core 3.0 Announcement Breaking change Documented The breaking change has been published to the .NET Core docs Migrated
Projects
None yet
Development

No branches or pull requests

4 participants