Skip to content

SignalR HandshakeProtocol.SuccessHandshakeData removed and replaced with helper method #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
analogrelay opened this issue Jun 11, 2019 · 0 comments
Open

SignalR HandshakeProtocol.SuccessHandshakeData removed and replaced with helper method #368

analogrelay opened this issue Jun 11, 2019 · 0 comments
Labels
3.0.0 Announcements related to ASP.NET Core 3.0 Announcement Breaking change Documented The breaking change has been published to the .NET Core docs Migrated

Comments

@analogrelay
Copy link

analogrelay commented Jun 11, 2019 •
edited by halter73
Loading

The HandshakeProtocol.SuccessHandshakeData field was removed and replaced with a helper method that generates a successful handshake response given a specific IHubProtocol. This change was made because additional fields were added to the handshake response that are non-constant and change depending on the selected protocol.

This type is not designed for use from user code, it is public so it can be shared between the SignalR server and client. It may also be used by customer SignalR clients written in .NET. Users of SignalR should not be affected by this change.

Use dotnet/aspnetcore#11098 to discuss this.

[This announcement has been migrated to: dotnet/docs#14943]
@analogrelay analogrelay added Announcement Breaking change 3.0.0 Announcements related to ASP.NET Core 3.0 labels Jun 11, 2019
@analogrelay analogrelay mentioned this issue Jun 11, 2019
Closed
@aspnet aspnet locked and limited conversation to collaborators Jun 11, 2019
@scottaddie scottaddie added the Documented The breaking change has been published to the .NET Core docs label Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3.0.0 Announcements related to ASP.NET Core 3.0 Announcement Breaking change Documented The breaking change has been published to the .NET Core docs Migrated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@analogrelay @halter73 @scottaddie