Skip to content

OAuthHandler ExchangeCodeAsync signature change #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tratcher opened this issue Jun 7, 2019 · 0 comments
Open

OAuthHandler ExchangeCodeAsync signature change #366

Tratcher opened this issue Jun 7, 2019 · 0 comments
Labels
3.0.0 Announcements related to ASP.NET Core 3.0 Breaking change Documented The breaking change has been published to the .NET Core docs Migrated

Comments

@Tratcher
Copy link
Member

Tratcher commented Jun 7, 2019

As part of dotnet/aspnetcore#10928, a breaking change was introduced in 3.0.0-preview7 where the signature of OAuthHandler.ExchangeCodeAsync was changed from:

protected virtual System.Threading.Tasks.Task<Microsoft.AspNetCore.Authentication.OAuth.OAuthTokenResponse> ExchangeCodeAsync(string code, string redirectUri) { throw null; }

To:

protected virtual System.Threading.Tasks.Task<Microsoft.AspNetCore.Authentication.OAuth.OAuthTokenResponse> ExchangeCodeAsync(Microsoft.AspNetCore.Authentication.OAuth.OAuthCodeExchangeContext context) { throw null; }

This change was made in order to flow additional parameters.

OAuth handlers that override this API will need to be updated.

See dotnet/aspnetcore#10991 for discussion.

[This announcement has been migrated to: dotnet/docs#14942]

@Tratcher Tratcher added Breaking change 3.0.0 Announcements related to ASP.NET Core 3.0 labels Jun 7, 2019
@Tratcher Tratcher added this to the 3.0.0-preview7 milestone Jun 7, 2019
@aspnet aspnet locked as resolved and limited conversation to collaborators Jun 7, 2019
@scottaddie scottaddie added the Documented The breaking change has been published to the .NET Core docs label Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.0.0 Announcements related to ASP.NET Core 3.0 Breaking change Documented The breaking change has been published to the .NET Core docs Migrated
Projects
None yet
Development

No branches or pull requests

3 participants