Skip to content

Add infrastructure for shared response types across operations #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add infrastructure for shared response types across operations #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96a7b0b
Add infrastructure for shared response types
devin-ai-integration[bot] Sep 24, 2025
21b8fa7
Fix trailing space lint issue in generateTypeName.kt
devin-ai-integration[bot] Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rc/main/kotlin/com/expediagroup/graphql/plugin/client/generator/GraphQLClientGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ class GraphQLClientGenerator(
// shared types
sharedTypes.putAll(context.enumClassToTypeSpecs.mapValues { listOf(it.value) })
sharedTypes.putAll(context.inputClassToTypeSpecs.mapValues { listOf(it.value) })
sharedTypes.putAll(context.responseClassToTypeSpecs.mapValues { listOf(it.value) })
context.scalarClassToConverterTypeSpecs
.values
.forEach {
Expand Down
1 change: 1 addition & 0 deletions .../kotlin/com/expediagroup/graphql/plugin/client/generator/GraphQLClientGeneratorContext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ data class GraphQLClientGeneratorContext(
// shared type caches
val enumClassToTypeSpecs: MutableMap<ClassName, TypeSpec> = mutableMapOf()
val inputClassToTypeSpecs: MutableMap<ClassName, TypeSpec> = mutableMapOf()
val responseClassToTypeSpecs: MutableMap<ClassName, TypeSpec> = mutableMapOf()
val scalarClassToConverterTypeSpecs: MutableMap<ClassName, ScalarConverterInfo> = mutableMapOf()
val typeAliases: MutableMap<String, TypeAliasSpec> = mutableMapOf()
internal fun isTypeAlias(typeName: String) = typeAliases.containsKey(typeName)
Expand Down
13 changes: 13 additions & 0 deletions ...rc/main/kotlin/com/expediagroup/graphql/plugin/client/generator/types/generateTypeName.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,3 +258,16 @@ private fun calculateSelectedFields(
}
return result
}

/**
* Find an existing shared response type for the given GraphQL type name
*/
private fun findSharedResponseType(
context: GraphQLClientGeneratorContext,
graphQLTypeName: String
): ClassName? {
return context.responseClassToTypeSpecs.keys.find { className ->
className.simpleName == graphQLTypeName &&
className.packageName.endsWith(".responses")
}
}