Master Update #81
Merged
Master Update #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed obselete sections from README
Make Seq generic
More detailed information on the new release can be found at the following URL https://github.com/arrayfire/arrayfire/releases/tag/v3.3.0
Defined and implemented a trait `HasAfEnum` for the types supported by ArrayFire. This trait is used by the Array creation and data generation functions now making the function API more terse. Changed the examples to reflect the new modifications.
Moved the following macros to separate module(macros) * mem_info * join_many
API Catchup to 3.3.0 version
unwrap index printing
Hotfix/index test
Very annoying doing:
```rust
if arr.dims().unwrap().get().clone() == arr2.dims().unwrap().get().clone() {}
```
Add support for partialeq & debug to dim4
Fixes #63
add clone and partialeq to all enums
* Retain the arrays returned from Features's accessors
With this change, all functions and operations return appropriate values/objects instead of wrapping those values inside a Result<> object. All errors reported by FFI calls are handled by a global error handling function that is registered by a call to the function `register_error_handler` that accepts either a closure or a function. By default, the error handler is set to a internal function that prints the error message to standard output and then panics.
Add tests directory with a function to check the function `register_error_handler`
Removed an incorrect implementation to provide thread safety for the function register_error_handler.
Also, modifies binary operators to use Array objects instead of borrowed references.
Replace Result returns in API with callback based error handling
Fixes #71 Compound operator traits are made stable in Rust 1.8, hence the version check is required
For some reason, directly passing a `&[]` to function that is using OpenCL backend is causing a SEGFAULT. This problem is however is not happening with CPU or CUDA backend. Moving the slice to a independent variable and then borrowing a reference is executing as expected on OSX. This may have to do with slices and the memory they are pointing to, but it is quite puzzling why it only happens on one of three backends.
I'm not on a system capable of testing, but currently our own dependency causes cargo to pull down both libc 0.1 & 0.2. We should update to libc 0.2 to combine dependencies. time is deprecated in favor of std::time
Rust enums use 8-bit number for representation of values where as c uses 32-bit number. This caused the issue in release mode. The compiler optimized these variables in release mode which must have caused over-bound writes thus causing the program crash. Fixes #73
After the fix, error module compiles fine with both 1.9.0 and 1.10.0 versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.