Skip to content

Commit 6039c16

Browse files
committed
configure: Remove clang version checks
We no C++ and an incredibly small amount of C code as part of the build, so there's not really much need for us to strictly check the version of compilers as we're not really stressing anything. LLVM is a pretty huge chunk of C++ but it should be the responsibility of LLVM to ensure that it can build with a particular clang/gcc version, not ours (as this logic changes over time). These version checks seem to basically just by us a regular stream of PRs every six weeks or so when a new version is releases, so they're not really buying us much. As a result, remove them and we can add then back piecemeal perhaps as a blacklist if we really need to.
1 parent da85ffb commit 6039c16

File tree

1 file changed

+0
-31
lines changed

1 file changed

+0
-31
lines changed

configure

-31
Original file line numberDiff line numberDiff line change
@@ -1028,37 +1028,6 @@ if [ -n "$CFG_ENABLE_CLANG" ]
10281028
then
10291029
case "$CC" in
10301030
(''|*clang)
1031-
CFG_CLANG_REPORTED_VERSION=$($CFG_CC --version | grep version)
1032-
1033-
if echo $CFG_CLANG_REPORTED_VERSION | grep -q "(based on LLVM "; then
1034-
CFG_CLANG_VERSION=$(echo $CFG_CLANG_REPORTED_VERSION | sed 's/.*(based on LLVM \(.*\))/\1/')
1035-
elif echo $CFG_CLANG_REPORTED_VERSION | grep -q "Apple LLVM"; then
1036-
CFG_OSX_CLANG_VERSION=$(echo $CFG_CLANG_REPORTED_VERSION | sed 's/.*version \(.*\) .*/\1/')
1037-
else
1038-
CFG_CLANG_VERSION=$(echo $CFG_CLANG_REPORTED_VERSION | sed 's/.*version \(.*\) .*/\1/')
1039-
fi
1040-
1041-
if [ -n "$CFG_OSX_CLANG_VERSION" ]
1042-
then
1043-
case $CFG_OSX_CLANG_VERSION in
1044-
(7.0* | 7.1* | 7.2* | 7.3*)
1045-
step_msg "found ok version of APPLE CLANG: $CFG_OSX_CLANG_VERSION"
1046-
;;
1047-
(*)
1048-
err "bad APPLE CLANG version: $CFG_OSX_CLANG_VERSION, need >=7.0"
1049-
;;
1050-
esac
1051-
else
1052-
case $CFG_CLANG_VERSION in
1053-
(3.2* | 3.3* | 3.4* | 3.5* | 3.6* | 3.7* | 3.8* | 3.9*)
1054-
step_msg "found ok version of CLANG: $CFG_CLANG_VERSION"
1055-
;;
1056-
(*)
1057-
err "bad CLANG version: $CFG_CLANG_VERSION, need >=3.0svn"
1058-
;;
1059-
esac
1060-
fi
1061-
10621031
if [ -z "$CC" ]
10631032
then
10641033
CFG_CC="clang"

0 commit comments

Comments
 (0)