Skip to content

Commit 058e9b0

Browse files
authored
[test] Don't check COMPILER_RT_STANDALONE_BUILD for deps (llvm#66259)
COMPILER_RT_STANDALONE_BUILD is only needed to be checked for dependencies outside of compiler-rt.
1 parent 37402c3 commit 058e9b0

File tree

11 files changed

+14
-28
lines changed

11 files changed

+14
-28
lines changed

compiler-rt/lib/msan/tests/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ macro(msan_link_shared so_list so_name arch kind)
7979
cmake_parse_arguments(SOURCE "" "" "OBJECTS;LINK_FLAGS;DEPS" ${ARGN})
8080
set(output_so "${CMAKE_CURRENT_BINARY_DIR}/${so_name}.${arch}${kind}.so")
8181
get_target_flags_for_arch(${arch} TARGET_LINK_FLAGS)
82-
if(NOT COMPILER_RT_STANDALONE_BUILD)
83-
list(APPEND SOURCE_DEPS msan)
84-
endif()
82+
list(APPEND SOURCE_DEPS msan)
8583
clang_link_shared(${output_so}
8684
OBJECTS ${SOURCE_OBJECTS}
8785
LINK_FLAGS ${COMPILER_RT_UNITTEST_LINK_FLAGS} ${TARGET_LINK_FLAGS} ${SOURCE_LINK_FLAGS}

compiler-rt/test/asan/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ macro(get_bits_for_arch arch bits)
2424
endmacro()
2525

2626
set(ASAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
27+
list(APPEND ASAN_TEST_DEPS asan)
2728
if(NOT COMPILER_RT_STANDALONE_BUILD)
28-
list(APPEND ASAN_TEST_DEPS asan)
2929
if(NOT APPLE AND COMPILER_RT_HAS_LLD AND "lld" IN_LIST LLVM_ENABLE_PROJECTS)
3030
list(APPEND ASAN_TEST_DEPS lld)
3131
endif()

compiler-rt/test/dfsan/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ foreach(arch ${DFSAN_TEST_ARCH})
2121
endforeach()
2222

2323
set(DFSAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
24-
if(NOT COMPILER_RT_STANDALONE_BUILD)
25-
list(APPEND DFSAN_TEST_DEPS dfsan)
26-
endif()
24+
list(APPEND DFSAN_TEST_DEPS dfsan)
2725

2826
add_lit_testsuite(check-dfsan "Running the DataFlowSanitizer tests"
2927
${DFSAN_TESTSUITES}

compiler-rt/test/hwasan/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ foreach(arch ${HWASAN_TEST_ARCH})
2121
endforeach()
2222

2323
set(HWASAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
24+
list(APPEND HWASAN_TEST_DEPS hwasan)
2425
if(NOT COMPILER_RT_STANDALONE_BUILD)
25-
list(APPEND HWASAN_TEST_DEPS hwasan)
2626
if(COMPILER_RT_HAS_LLD AND "lld" IN_LIST LLVM_ENABLE_PROJECTS)
2727
list(APPEND HWASAN_TEST_DEPS lld)
2828
endif()

compiler-rt/test/lsan/CMakeLists.txt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,9 @@ foreach(arch ${LSAN_TEST_ARCH})
4242
endforeach()
4343

4444
set(LSAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
45-
if(NOT COMPILER_RT_STANDALONE_BUILD)
46-
list(APPEND LSAN_TEST_DEPS lsan)
47-
append_list_if(COMPILER_RT_HAS_ASAN asan LSAN_TEST_DEPS)
48-
append_list_if(COMPILER_RT_HAS_HWASAN hwasan LSAN_TEST_DEPS)
49-
endif()
45+
list(APPEND LSAN_TEST_DEPS lsan)
46+
append_list_if(COMPILER_RT_HAS_ASAN asan LSAN_TEST_DEPS)
47+
append_list_if(COMPILER_RT_HAS_HWASAN hwasan LSAN_TEST_DEPS)
5048
add_lit_testsuite(check-lsan "Running the LeakSanitizer tests"
5149
${LSAN_TESTSUITES}
5250
DEPENDS ${LSAN_TEST_DEPS})

compiler-rt/test/metadata/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ if(CAN_TARGET_x86_64)
55
set(METADATA_LIT_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
66

77
set(METADATA_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
8-
if (NOT COMPILER_RT_STANDALONE_BUILD)
9-
list(APPEND METADATA_TEST_DEPS asan ubsan)
10-
endif()
8+
list(APPEND METADATA_TEST_DEPS asan ubsan)
119

1210
set(SANITIZER_COMMON_TEST_TARGET_ARCH ${X86_64})
1311
get_test_cc_for_arch(x86_64 METADATA_TEST_TARGET_CC METADATA_TEST_TARGET_CFLAGS)

compiler-rt/test/profile/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ set(PROFILE_LIT_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
44
set(PROFILE_TESTSUITES)
55
# Profile tests rely on the compiler-rt-headers being in the resource directory
66
set(PROFILE_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS} compiler-rt-headers)
7+
list(APPEND PROFILE_TEST_DEPS profile)
78
if(NOT COMPILER_RT_STANDALONE_BUILD)
8-
list(APPEND PROFILE_TEST_DEPS profile llvm-profdata llvm-cov)
9+
list(APPEND PROFILE_TEST_DEPS llvm-profdata llvm-cov)
910
if(NOT APPLE AND COMPILER_RT_HAS_LLD AND "lld" IN_LIST LLVM_ENABLE_PROJECTS)
1011
list(APPEND PROFILE_TEST_DEPS lld)
1112
endif()

compiler-rt/test/safestack/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ set(SAFESTACK_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
22
set(SAFESTACK_LIT_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
33

44
set(SAFESTACK_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
5+
list(APPEND SAFESTACK_TEST_DEPS safestack)
56
if(NOT COMPILER_RT_STANDALONE_BUILD)
6-
list(APPEND SAFESTACK_TEST_DEPS safestack)
7-
87
# Some tests require LTO, so add a dependency on the relevant LTO plugin.
98
if(LLVM_ENABLE_PIC)
109
if(LLVM_BINUTILS_INCDIR)

compiler-rt/test/tsan/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@ set(TSAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
44
if(${COMPILER_RT_DEFAULT_TARGET_ARCH} MATCHES "(x86_64|s390x)")
55
list(APPEND TSAN_TEST_DEPS GotsanRuntimeCheck)
66
endif()
7-
if(NOT COMPILER_RT_STANDALONE_BUILD)
8-
list(APPEND TSAN_TEST_DEPS tsan)
9-
endif()
7+
list(APPEND TSAN_TEST_DEPS tsan)
108
if(COMPILER_RT_LIBCXX_PATH AND
119
COMPILER_RT_LIBCXXABI_PATH AND
1210
COMPILER_RT_TEST_COMPILER_ID STREQUAL "Clang"

compiler-rt/test/ubsan/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,7 @@ macro(add_ubsan_device_testsuite test_mode sanitizer platform arch)
8686
${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
8787
${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/lit.site.cfg.py)
8888
#list(APPEND UBSAN_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME})
89-
if(NOT COMPILER_RT_STANDALONE_BUILD)
90-
list(APPEND UBSAN_TEST_DEPS ${sanitizer})
91-
endif()
89+
list(APPEND UBSAN_TEST_DEPS ${sanitizer})
9290
add_lit_testsuite(check-ubsan-${test_mode}-${platform}-${arch}
9391
"UBSan ${CONFIG_NAME} tests"
9492
${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/

compiler-rt/test/ubsan_minimal/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ endif()
77

88
set(UBSAN_TESTSUITES)
99
set(UBSAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
10-
if(NOT COMPILER_RT_STANDALONE_BUILD)
11-
list(APPEND UBSAN_TEST_DEPS ubsan-minimal)
12-
endif()
10+
list(APPEND UBSAN_TEST_DEPS ubsan-minimal)
1311

1412
foreach(arch ${UBSAN_TEST_ARCH})
1513
get_test_cc_for_arch(${arch} UBSAN_TEST_TARGET_CC UBSAN_TEST_TARGET_CFLAGS)

0 commit comments

Comments
 (0)