fix: programmer is optional for debug -I check

Ref: arduino/arduino-ide#2371
Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

src/debug.ts

@@ -142,9 +142,6 @@ async function createLaunchConfig(
   params: StartDebugParams
 ): Promise<ArduinoDebugLaunchConfig> {
   const { programmer, board } = params;
-  if (!programmer) {
-    throw new Error('Missing programmer');
-  }
   const { file, args } = buildDebugInfoArgs(params);
   const [stdout, customConfigs] = await Promise.all([
     withProgress(
@@ -206,8 +203,14 @@ async function parseRawDebugInfo(
   return config;
 }
 
-function createConfigId(board: BoardIdentifier, programmer: string): string {
+function createConfigId(
+  board: BoardIdentifier,
+  programmer: string | undefined
+): string {
   const fqbn = new FQBN(board.fqbn);
+  if (!programmer) {
+    return fqbn.toString();
+  }
   if (hasConfigOptions(fqbn)) {
     // if already has config options, append the programmer as an ordinary custom board config option
     return `${fqbn.toString()},programmer=${programmer}`;
@@ -294,7 +297,7 @@ function resolveCliConfigPath(
 
 async function mergeLaunchConfig(
   board: BoardIdentifier,
-  programmer: string,
+  programmer: string | undefined,
   debugInfo: DebugInfo & Executable,
   customConfigs: CustomDebugConfigs
 ): Promise<ArduinoDebugLaunchConfig> {
@@ -326,7 +329,10 @@ async function mergeLaunchConfig(
   return launchConfig;
 }
 
-function createName(board: BoardIdentifier, programmer: string): string {
+function createName(
+  board: BoardIdentifier,
+  programmer: string | undefined
+): string {
   if (!board.name) {
     const configId = createConfigId(board, programmer);
     return `Arduino (${configId})`;
@@ -336,9 +342,9 @@ function createName(board: BoardIdentifier, programmer: string): string {
     const options = Object.entries(fqbn.options)
       .map(([key, value]) => `${key}=${value}`)
       .join(',');
-    return `${board.name} (${options},${programmer})`;
+    return `${board.name} (${options}${programmer ? `,${programmer}` : ''})`;
   }
-  return `${board.name} (${programmer})`;
+  return `${board.name}${programmer ? ` (${programmer})` : ''}`;
 }
 
 function replaceValue(

src/test/suite/debug.test.ts

@@ -363,10 +363,21 @@ describe('debug', () => {
       const actual = createConfigId({ fqbn: 'a:b:c' }, 'p');
       assert.strictEqual(actual, 'a:b:c:programmer=p');
     });
+
+    it('should create the configuration ID when the FQBN has no custom board options (no programmer)', () => {
+      const actual = createConfigId({ fqbn: 'a:b:c' }, undefined);
+      assert.strictEqual(actual, 'a:b:c');
+    });
+
     it('should create the configuration ID when the FQBN has custom board options', () => {
       const actual = createConfigId({ fqbn: 'a:b:c:o1=v1' }, 'p');
       assert.strictEqual(actual, 'a:b:c:o1=v1,programmer=p');
     });
+
+    it('should create the configuration ID when the FQBN has custom board options (no programmer)', () => {
+      const actual = createConfigId({ fqbn: 'a:b:c:o1=v1' }, undefined);
+      assert.strictEqual(actual, 'a:b:c:o1=v1');
+    });
   });
   describe('createName', () => {
     it('should use the generated config ID if the board name is absent', () => {
@@ -386,19 +397,37 @@ describe('debug', () => {
       );
     });
 
+    it('should use the generated config ID with the custom board options if the board name is absent (no programmer)', () => {
+      const board = { fqbn: 'a:b:c:UsbMode=default' };
+      const actual = createName(board, undefined);
+      assert.strictEqual(actual, 'Arduino (a:b:c:UsbMode=default)');
+    });
+
     it('should use the board name', () => {
       const board = { fqbn: 'a:b:c', name: 'board name' };
       const programmer = 'p1';
       const actual = createName(board, programmer);
       assert.strictEqual(actual, 'board name (p1)');
     });
 
+    it('should use the board name (no programmer)', () => {
+      const board = { fqbn: 'a:b:c', name: 'board name' };
+      const actual = createName(board, undefined);
+      assert.strictEqual(actual, 'board name');
+    });
+
     it('should use the board name and all custom board options', () => {
       const board = { fqbn: 'a:b:c:UsbMode=default', name: 'board name' };
       const programmer = 'p1';
       const actual = createName(board, programmer);
       assert.strictEqual(actual, 'board name (UsbMode=default,p1)');
     });
+
+    it('should use the board name and all custom board options (no programmer)', () => {
+      const board = { fqbn: 'a:b:c:UsbMode=default', name: 'board name' };
+      const actual = createName(board, undefined);
+      assert.strictEqual(actual, 'board name (UsbMode=default)');
+    });
   });
 
   describe('isCustomDebugConfig', () => {