Skip to content

Commit b78b870

Browse files
committed
Remove outdated action version specification from comments
The workflow is using v3 now, and there has not been any on the permissions situation documented by this comment: https://github.com/actions/upload-artifact/tree/v3#permission-loss Since we have gotten behind on this comment at each bump and there is no sign that they will ever change the behavior (and also no reason to believe that it would align with a major version bump even if they did), I think it is best to just remove the version specification from the comment altogether.
1 parent 7b70c17 commit b78b870

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

workflow-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-nightly-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
9999
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
100100
run: |
101-
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
101+
# GitHub's upload/download-artifact actions don't preserve file permissions,
102102
# so we need to add execution permission back until the action is made to do this.
103103
chmod +x "${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_darwin_amd64/${{ env.PROJECT_NAME }}"
104104
PACKAGE_FILENAME="$(basename ${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_nightly-*_macOS_64bit.tar.gz)"

workflow-templates/dependabot/workflow-template-copies/.github/workflows/release-go-crosscompile-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
111111
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
112112
run: |
113-
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
113+
# GitHub's upload/download-artifact actions don't preserve file permissions,
114114
# so we need to add execution permission back until the action is made to do this.
115115
chmod +x ${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_darwin_amd64/${{ env.PROJECT_NAME }}
116116
TAG="${GITHUB_REF/refs\/tags\//}"

workflow-templates/dependabot/workflow-template-copies/.github/workflows/release-go-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
104104
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
105105
run: |
106-
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
106+
# GitHub's upload/download-artifact actions don't preserve file permissions,
107107
# so we need to add execution permission back until the action is made to do this.
108108
chmod +x ${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_darwin_amd64/${{ env.PROJECT_NAME }}
109109
TAG="${GITHUB_REF/refs\/tags\//}"

workflow-templates/publish-go-nightly-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
9999
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
100100
run: |
101-
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
101+
# GitHub's upload/download-artifact actions don't preserve file permissions,
102102
# so we need to add execution permission back until the action is made to do this.
103103
chmod +x "${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_darwin_amd64/${{ env.PROJECT_NAME }}"
104104
PACKAGE_FILENAME="$(basename ${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_nightly-*_macOS_64bit.tar.gz)"

workflow-templates/release-go-crosscompile-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
111111
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
112112
run: |
113-
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
113+
# GitHub's upload/download-artifact actions don't preserve file permissions,
114114
# so we need to add execution permission back until the action is made to do this.
115115
chmod +x ${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_darwin_amd64/${{ env.PROJECT_NAME }}
116116
TAG="${GITHUB_REF/refs\/tags\//}"

workflow-templates/release-go-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
# 1. Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
104104
# 2. Recalculate package checksum and replace it in the nnnnnn-checksums.txt file
105105
run: |
106-
# GitHub's upload/download-artifact@v2 actions don't preserve file permissions,
106+
# GitHub's upload/download-artifact actions don't preserve file permissions,
107107
# so we need to add execution permission back until the action is made to do this.
108108
chmod +x ${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_darwin_amd64/${{ env.PROJECT_NAME }}
109109
TAG="${GITHUB_REF/refs\/tags\//}"

0 commit comments

Comments
 (0)