Skip to content

Commit b998e03

Browse files
committed
Remove redundant ts:install-deps task
Previously a task named ts:install-deps was used to install the npm-managed dependencies of the project. At the time the task was added, npm was used to manage the action's TypeScript code dependencies as well as TypeScript-specific development tool dependencies. For this reason, it seemed reasonable to use the "ts" prefix on the task name to place it under the TypeScript "namespace" of tasks. In addition to the TypeScript-specific dependencies, npm is now used to manage tool dependencies for general management of the project not specific to TypeScript. For this reason, and because it is now the standardized task name used by the reusable "template" assets, it is better to use the task with the more appropriate "npm" prefix.
1 parent e22b976 commit b998e03

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

Taskfile.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -249,34 +249,29 @@ tasks:
249249
ts:build:
250250
desc: Build the action's TypeScript code.
251251
deps:
252-
- task: ts:install-deps
252+
- task: npm:install-deps
253253
cmds:
254254
- npx tsc
255255
- npx ncc build
256256

257257
ts:fix-lint:
258258
desc: Fix TypeScript code linting violations
259259
deps:
260-
- task: ts:install-deps
260+
- task: npm:install-deps
261261
cmds:
262262
- npx eslint --ext .js,.jsx,.ts,.tsx --fix .
263263

264-
ts:install-deps:
265-
desc: Install TypeScript dependencies
266-
deps:
267-
- task: npm:install-deps
268-
269264
ts:lint:
270265
desc: Lint TypeScript code
271266
deps:
272-
- task: ts:install-deps
267+
- task: npm:install-deps
273268
cmds:
274269
- npx eslint --ext .js,.jsx,.ts,.tsx .
275270

276271
ts:test:
277272
desc: Test the action's TypeScript code.
278273
deps:
279-
- task: ts:install-deps
274+
- task: npm:install-deps
280275
cmds:
281276
- npx jest
282277

0 commit comments

Comments
 (0)