Skip to content

Commit 90b2343

Browse files
authored
Merge pull request #38 from arduino/update-workflows
Apply update of workflows from asset repo
2 parents 9fefd71 + 31c7c6c commit 90b2343

11 files changed

+130
-107
lines changed

.github/workflows/check-go-dependencies-task.yml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ on:
3737
jobs:
3838
run-determination:
3939
runs-on: ubuntu-latest
40+
permissions: {}
4041
outputs:
4142
result: ${{ steps.determination.outputs.result }}
4243
steps:
@@ -62,10 +63,12 @@ jobs:
6263
needs: run-determination
6364
if: needs.run-determination.outputs.result == 'true'
6465
runs-on: ubuntu-latest
66+
permissions:
67+
contents: read
6568

6669
steps:
6770
- name: Checkout repository
68-
uses: actions/checkout@v3
71+
uses: actions/checkout@v4
6972
with:
7073
submodules: recursive
7174

@@ -82,12 +85,12 @@ jobs:
8285
version: 4.x
8386

8487
- name: Install Go
85-
uses: actions/setup-go@v4
88+
uses: actions/setup-go@v5
8689
with:
8790
go-version: ${{ env.GO_VERSION }}
8891

8992
- name: Install Task
90-
uses: arduino/setup-task@v1
93+
uses: arduino/setup-task@v2
9194
with:
9295
repo-token: ${{ secrets.GITHUB_TOKEN }}
9396
version: 3.x
@@ -118,10 +121,12 @@ jobs:
118121
needs: run-determination
119122
if: needs.run-determination.outputs.result == 'true'
120123
runs-on: ubuntu-latest
124+
permissions:
125+
contents: read
121126

122127
steps:
123128
- name: Checkout repository
124-
uses: actions/checkout@v3
129+
uses: actions/checkout@v4
125130
with:
126131
submodules: recursive
127132

@@ -138,12 +143,12 @@ jobs:
138143
version: 4.x
139144

140145
- name: Install Go
141-
uses: actions/setup-go@v4
146+
uses: actions/setup-go@v5
142147
with:
143148
go-version: ${{ env.GO_VERSION }}
144149

145150
- name: Install Task
146-
uses: arduino/setup-task@v1
151+
uses: arduino/setup-task@v2
147152
with:
148153
repo-token: ${{ secrets.GITHUB_TOKEN }}
149154
version: 3.x

.github/workflows/check-go-task.yml

Lines changed: 26 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,15 @@ on:
1212
paths:
1313
- ".github/workflows/check-go-task.ya?ml"
1414
- "Taskfile.ya?ml"
15+
- ".golangci.ya?ml"
1516
- "**/go.mod"
1617
- "**/go.sum"
1718
- "**.go"
1819
pull_request:
1920
paths:
2021
- ".github/workflows/check-go-task.ya?ml"
2122
- "Taskfile.ya?ml"
23+
- ".golangci.ya?ml"
2224
- "**/go.mod"
2325
- "**/go.sum"
2426
- "**.go"
@@ -31,6 +33,7 @@ on:
3133
jobs:
3234
run-determination:
3335
runs-on: ubuntu-latest
36+
permissions: {}
3437
outputs:
3538
result: ${{ steps.determination.outputs.result }}
3639
steps:
@@ -52,49 +55,13 @@ jobs:
5255
5356
echo "result=$RESULT" >> $GITHUB_OUTPUT
5457
55-
check-errors:
56-
name: check-errors (${{ matrix.module.path }})
57-
needs: run-determination
58-
if: needs.run-determination.outputs.result == 'true'
59-
runs-on: ubuntu-latest
60-
61-
strategy:
62-
fail-fast: false
63-
64-
matrix:
65-
module:
66-
- path: ./
67-
68-
steps:
69-
- name: Checkout repository
70-
uses: actions/checkout@v3
71-
72-
- name: Install Go
73-
uses: actions/setup-go@v3
74-
with:
75-
go-version: ${{ env.GO_VERSION }}
76-
77-
- name: Install Task
78-
uses: arduino/setup-task@v1
79-
with:
80-
repo-token: ${{ secrets.GITHUB_TOKEN }}
81-
version: 3.x
82-
83-
- name: Download external files
84-
run: |
85-
task download-dfu-util
86-
task download-libusb
87-
88-
- name: Check for errors
89-
env:
90-
GO_MODULE_PATH: ${{ matrix.module.path }}
91-
run: task go:vet
92-
9358
check-outdated:
9459
name: check-outdated (${{ matrix.module.path }})
9560
needs: run-determination
9661
if: needs.run-determination.outputs.result == 'true'
9762
runs-on: ubuntu-latest
63+
permissions:
64+
contents: read
9865

9966
strategy:
10067
fail-fast: false
@@ -105,15 +72,15 @@ jobs:
10572

10673
steps:
10774
- name: Checkout repository
108-
uses: actions/checkout@v3
75+
uses: actions/checkout@v4
10976

11077
- name: Install Go
111-
uses: actions/setup-go@v3
78+
uses: actions/setup-go@v5
11279
with:
11380
go-version: ${{ env.GO_VERSION }}
11481

11582
- name: Install Task
116-
uses: arduino/setup-task@v1
83+
uses: arduino/setup-task@v2
11784
with:
11885
repo-token: ${{ secrets.GITHUB_TOKEN }}
11986
version: 3.x
@@ -131,6 +98,8 @@ jobs:
13198
needs: run-determination
13299
if: needs.run-determination.outputs.result == 'true'
133100
runs-on: ubuntu-latest
101+
permissions:
102+
contents: read
134103

135104
strategy:
136105
fail-fast: false
@@ -141,21 +110,23 @@ jobs:
141110

142111
steps:
143112
- name: Checkout repository
144-
uses: actions/checkout@v3
113+
uses: actions/checkout@v4
145114

146115
- name: Install Go
147-
uses: actions/setup-go@v3
116+
uses: actions/setup-go@v5
148117
with:
149118
go-version: ${{ env.GO_VERSION }}
150119

151120
- name: Install Task
152-
uses: arduino/setup-task@v1
121+
uses: arduino/setup-task@v2
153122
with:
154123
repo-token: ${{ secrets.GITHUB_TOKEN }}
155124
version: 3.x
156125

157-
- name: Install golint
158-
run: go install golang.org/x/lint/golint@latest
126+
- name: Install golangci-lint
127+
uses: golangci/golangci-lint-action@v3
128+
with:
129+
version: v1.54
159130

160131
- name: Check style
161132
env:
@@ -167,6 +138,8 @@ jobs:
167138
needs: run-determination
168139
if: needs.run-determination.outputs.result == 'true'
169140
runs-on: ubuntu-latest
141+
permissions:
142+
contents: read
170143

171144
strategy:
172145
fail-fast: false
@@ -177,15 +150,15 @@ jobs:
177150

178151
steps:
179152
- name: Checkout repository
180-
uses: actions/checkout@v3
153+
uses: actions/checkout@v4
181154

182155
- name: Install Go
183-
uses: actions/setup-go@v3
156+
uses: actions/setup-go@v5
184157
with:
185158
go-version: ${{ env.GO_VERSION }}
186159

187160
- name: Install Task
188-
uses: arduino/setup-task@v1
161+
uses: arduino/setup-task@v2
189162
with:
190163
repo-token: ${{ secrets.GITHUB_TOKEN }}
191164
version: 3.x
@@ -203,6 +176,8 @@ jobs:
203176
needs: run-determination
204177
if: needs.run-determination.outputs.result == 'true'
205178
runs-on: ubuntu-latest
179+
permissions:
180+
contents: read
206181

207182
strategy:
208183
fail-fast: false
@@ -213,10 +188,10 @@ jobs:
213188

214189
steps:
215190
- name: Checkout repository
216-
uses: actions/checkout@v3
191+
uses: actions/checkout@v4
217192

218193
- name: Install Go
219-
uses: actions/setup-go@v3
194+
uses: actions/setup-go@v5
220195
with:
221196
go-version: ${{ env.GO_VERSION }}
222197

.github/workflows/check-license.yml

Lines changed: 24 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-license.md
22
name: Check License
33

4-
env:
5-
EXPECTED_LICENSE_FILENAME: LICENSE.txt
6-
# SPDX identifier: https://spdx.org/licenses/
7-
EXPECTED_LICENSE_TYPE: GPL-3.0
8-
94
# See: https://docs.github.com/actions/using-workflows/events-that-trigger-workflows
105
on:
116
create:
@@ -35,6 +30,7 @@ on:
3530
jobs:
3631
run-determination:
3732
runs-on: ubuntu-latest
33+
permissions: {}
3834
outputs:
3935
result: ${{ steps.determination.outputs.result }}
4036
steps:
@@ -57,13 +53,26 @@ jobs:
5753
echo "result=$RESULT" >> $GITHUB_OUTPUT
5854
5955
check-license:
56+
name: ${{ matrix.check-license.path }}
6057
needs: run-determination
6158
if: needs.run-determination.outputs.result == 'true'
6259
runs-on: ubuntu-latest
60+
permissions:
61+
contents: read
62+
63+
strategy:
64+
fail-fast: false
65+
66+
matrix:
67+
check-license:
68+
- path: ./
69+
expected-filename: LICENSE.txt
70+
# SPDX identifier: https://spdx.org/licenses/
71+
expected-type: GPL-3.0
6372

6473
steps:
6574
- name: Checkout repository
66-
uses: actions/checkout@v3
75+
uses: actions/checkout@v4
6776

6877
- name: Install Ruby
6978
uses: ruby/setup-ruby@v1
@@ -73,23 +82,27 @@ jobs:
7382
- name: Install licensee
7483
run: gem install licensee
7584

76-
- name: Check license file
85+
- name: Check license file for ${{ matrix.check-license.path }}
7786
run: |
7887
EXIT_STATUS=0
88+
89+
# Go into folder path
90+
cd ./${{ matrix.check-license.path }}
91+
7992
# See: https://github.com/licensee/licensee
8093
LICENSEE_OUTPUT="$(licensee detect --json --confidence=100)"
8194
8295
DETECTED_LICENSE_FILE="$(echo "$LICENSEE_OUTPUT" | jq .matched_files[0].filename | tr --delete '\r')"
8396
echo "Detected license file: $DETECTED_LICENSE_FILE"
84-
if [ "$DETECTED_LICENSE_FILE" != "\"${EXPECTED_LICENSE_FILENAME}\"" ]; then
85-
echo "::error file=${DETECTED_LICENSE_FILE}::detected license file $DETECTED_LICENSE_FILE doesn't match expected: $EXPECTED_LICENSE_FILENAME"
97+
if [ "$DETECTED_LICENSE_FILE" != "\"${{ matrix.check-license.expected-filename }}\"" ]; then
98+
echo "::error file=${DETECTED_LICENSE_FILE}::detected license file $DETECTED_LICENSE_FILE doesn't match expected: ${{ matrix.check-license.expected-filename }}"
8699
EXIT_STATUS=1
87100
fi
88101
89102
DETECTED_LICENSE_TYPE="$(echo "$LICENSEE_OUTPUT" | jq .matched_files[0].matched_license | tr --delete '\r')"
90103
echo "Detected license type: $DETECTED_LICENSE_TYPE"
91-
if [ "$DETECTED_LICENSE_TYPE" != "\"${EXPECTED_LICENSE_TYPE}\"" ]; then
92-
echo "::error file=${DETECTED_LICENSE_FILE}::detected license type $DETECTED_LICENSE_TYPE doesn't match expected \"${EXPECTED_LICENSE_TYPE}\""
104+
if [ "$DETECTED_LICENSE_TYPE" != "\"${{ matrix.check-license.expected-type }}\"" ]; then
105+
echo "::error file=${DETECTED_LICENSE_FILE}::detected license type $DETECTED_LICENSE_TYPE doesn't match expected \"${{ matrix.check-license.expected-type }}\""
93106
EXIT_STATUS=1
94107
fi
95108

.github/workflows/check-markdown-task.yml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ on:
4141
jobs:
4242
run-determination:
4343
runs-on: ubuntu-latest
44+
permissions: {}
4445
outputs:
4546
result: ${{ steps.determination.outputs.result }}
4647
steps:
@@ -66,21 +67,23 @@ jobs:
6667
needs: run-determination
6768
if: needs.run-determination.outputs.result == 'true'
6869
runs-on: ubuntu-latest
70+
permissions:
71+
contents: read
6972

7073
steps:
7174
- name: Checkout repository
72-
uses: actions/checkout@v3
75+
uses: actions/checkout@v4
7376

7477
- name: Setup Node.js
75-
uses: actions/setup-node@v3
78+
uses: actions/setup-node@v4
7679
with:
7780
node-version: ${{ env.NODE_VERSION }}
7881

7982
- name: Initialize markdownlint-cli problem matcher
80-
uses: xt0rted/markdownlint-problem-matcher@v2
83+
uses: xt0rted/markdownlint-problem-matcher@v3
8184

8285
- name: Install Task
83-
uses: arduino/setup-task@v1
86+
uses: arduino/setup-task@v2
8487
with:
8588
repo-token: ${{ secrets.GITHUB_TOKEN }}
8689
version: 3.x
@@ -92,18 +95,20 @@ jobs:
9295
needs: run-determination
9396
if: needs.run-determination.outputs.result == 'true'
9497
runs-on: ubuntu-latest
98+
permissions:
99+
contents: read
95100

96101
steps:
97102
- name: Checkout repository
98-
uses: actions/checkout@v3
103+
uses: actions/checkout@v4
99104

100105
- name: Setup Node.js
101-
uses: actions/setup-node@v3
106+
uses: actions/setup-node@v4
102107
with:
103108
node-version: ${{ env.NODE_VERSION }}
104109

105110
- name: Install Task
106-
uses: arduino/setup-task@v1
111+
uses: arduino/setup-task@v2
107112
with:
108113
repo-token: ${{ secrets.GITHUB_TOKEN }}
109114
version: 3.x

0 commit comments

Comments
 (0)