fix: force workaround logic run when # in the path

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/node/theia/plugin-ext/plugin-deployer.ts

@@ -18,13 +18,19 @@ export class LocalDirectoryPluginDeployerResolverWithFallback extends LocalDirec
   override async resolve(
     pluginResolverContext: PluginDeployerResolverContext
   ): Promise<void> {
-    let localPath = await this.originalResolveLocalPluginPath(
-      pluginResolverContext,
-      this.supportedScheme
-    );
-    // If local plugins folder was not resoled, fallback to the hack.
-    if (!localPath) {
-      localPath = await resolveLocalPluginPath(
+    const origin = pluginResolverContext.getOriginId();
+    // The original implementation must not run when there is a hash in the path. Otherwise, it can resolve an undesired directory.
+    // Consider app under c:\Users\username\Desktop\# here is my app\
+    // Then the flawed logic will incorrectly find c:\Users\username\Desktop location after stripping the rest of the path after the hash.
+    // The implementation which provides a workaround for the hash in the path assumes that the original Theia logic is correct, when no hash present in the URI path.
+    let localPath: string | null;
+    if (origin.includes('#')) {
+      localPath = await resolveLocalPluginPathFallback(
+        pluginResolverContext,
+        this.supportedScheme
+      );
+    } else {
+      localPath = await this.originalResolveLocalPluginPath(
         pluginResolverContext,
         this.supportedScheme
       );
@@ -49,14 +55,14 @@ export class LocalDirectoryPluginDeployerResolverWithFallback extends LocalDirec
   }
 }
 
-async function resolveLocalPluginPath(
+async function resolveLocalPluginPathFallback(
   context: PluginDeployerResolverContext,
   scheme: string
 ): Promise<string | null> {
-  const origin = context.getOriginId();
-  const uri = new URI(origin);
+  const uri = new URI(context.getOriginId());
   if (uri.scheme === scheme) {
-    let fsPath = origin.substring(`${scheme}:`.length);
+    const unencodedRawUri = uri.toString(true);
+    let fsPath = unencodedRawUri.substring(`${scheme}:`.length);
     if (!isAbsolute(fsPath)) {
       fsPath = resolve(process.cwd(), fsPath);
     }