Propagate context everywhere

Author: polldo

arduino/commander.go

@@ -18,13 +18,15 @@
 package arduino
 
 import (
+	"context"
+
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 )
 
 // Commander of arduino package allows to call
 // the arduino-cli commands in a programmatic way.
 type Commander interface {
-	BoardList() ([]*rpc.DetectedPort, error)
-	UploadBin(fqbn, bin, address, protocol string) error
+	BoardList(ctx context.Context) ([]*rpc.DetectedPort, error)
+	UploadBin(ctx context.Context, fqbn, bin, address, protocol string) error
 	//Compile() error
 }

arduino/grpc/board.go

@@ -30,7 +30,7 @@ type boardHandler struct {
 
 // BoardList executes the 'arduino-cli board list' command
 // and returns its result.
-func (b boardHandler) BoardList() ([]*rpc.DetectedPort, error) {
+func (b boardHandler) BoardList(ctx context.Context) ([]*rpc.DetectedPort, error) {
 	boardListResp, err := b.serviceClient.BoardList(context.Background(),
 		&rpc.BoardListRequest{Instance: b.instance})
 

arduino/grpc/compile.go

@@ -38,7 +38,7 @@ func (c compileHandler) Compile() error {
 
 // Upload executes the 'arduino-cli upload -i' command
 // and returns its result.
-func (c compileHandler) UploadBin(fqbn, bin, address, protocol string) error {
+func (c compileHandler) UploadBin(ctx context.Context, fqbn, bin, address, protocol string) error {
 	stream, err := c.serviceClient.Upload(context.Background(),
 		&rpc.UploadRequest{
 			Instance:   c.instance,

cli/dashboard/create.go

@@ -18,6 +18,7 @@
 package dashboard
 
 import (
+	"context"
 	"fmt"
 	"os"
 	"strings"
@@ -76,7 +77,7 @@ func runCreateCommand(flags *createFlags) error {
 		params.Name = &flags.name
 	}
 
-	dashboard, err := dashboard.Create(params, cred)
+	dashboard, err := dashboard.Create(context.TODO(), params, cred)
 	if err != nil {
 		return err
 	}

cli/dashboard/delete.go

@@ -18,6 +18,7 @@
 package dashboard
 
 import (
+	"context"
 	"fmt"
 	"os"
 
@@ -60,7 +61,7 @@ func runDeleteCommand(flags *deleteFlags) error {
 	}
 
 	params := &dashboard.DeleteParams{ID: flags.id}
-	err = dashboard.Delete(params, cred)
+	err = dashboard.Delete(context.TODO(), params, cred)
 	if err != nil {
 		return err
 	}

cli/dashboard/extract.go

@@ -18,6 +18,7 @@
 package dashboard
 
 import (
+	"context"
 	"fmt"
 	"os"
 
@@ -64,7 +65,7 @@ func runExtractCommand(flags *extractFlags) error {
 		ID: flags.id,
 	}
 
-	template, err := dashboard.Extract(params, cred)
+	template, err := dashboard.Extract(context.TODO(), params, cred)
 	if err != nil {
 		return err
 	}

cli/dashboard/list.go

@@ -18,6 +18,7 @@
 package dashboard
 
 import (
+	"context"
 	"fmt"
 	"math"
 	"os"
@@ -66,7 +67,7 @@ func runListCommand(flags *listFlags) error {
 		return fmt.Errorf("retrieving credentials: %w", err)
 	}
 
-	dash, err := dashboard.List(cred)
+	dash, err := dashboard.List(context.TODO(), cred)
 	if err != nil {
 		return err
 	}

cli/device/create.go

@@ -18,8 +18,11 @@
 package device
 
 import (
+	"context"
 	"fmt"
 	"os"
+	"os/signal"
+	"syscall"
 
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
@@ -73,7 +76,15 @@ func runCreateCommand(flags *createFlags) error {
 		params.FQBN = &flags.fqbn
 	}
 
-	dev, err := device.Create(params, cred)
+	ctx, canc := context.WithCancel(context.Background())
+	ch := make(chan os.Signal)
+	signal.Notify(ch, os.Interrupt, syscall.SIGTERM)
+	go func() {
+		<-ch
+		canc()
+	}()
+
+	dev, err := device.Create(ctx, params, cred)
 	if err != nil {
 		return err
 	}

cli/device/creategeneric.go

@@ -18,8 +18,11 @@
 package device
 
 import (
+	"context"
 	"fmt"
 	"os"
+	"os/signal"
+	"syscall"
 
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
@@ -66,7 +69,15 @@ func runCreateGenericCommand(flags *createGenericFlags) error {
 		FQBN: flags.fqbn,
 	}
 
-	dev, err := device.CreateGeneric(params, cred)
+	ctx, canc := context.WithCancel(context.Background())
+	ch := make(chan os.Signal)
+	signal.Notify(ch, os.Interrupt, syscall.SIGTERM)
+	go func() {
+		<-ch
+		canc()
+	}()
+
+	dev, err := device.CreateGeneric(ctx, params, cred)
 	if err != nil {
 		return err
 	}

cli/device/createlora.go

@@ -18,8 +18,11 @@
 package device
 
 import (
+	"context"
 	"fmt"
 	"os"
+	"os/signal"
+	"syscall"
 
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
@@ -80,7 +83,15 @@ func runCreateLoraCommand(flags *createLoraFlags) error {
 		params.FQBN = &flags.fqbn
 	}
 
-	dev, err := device.CreateLora(params, cred)
+	ctx, canc := context.WithCancel(context.Background())
+	ch := make(chan os.Signal)
+	signal.Notify(ch, os.Interrupt, syscall.SIGTERM)
+	go func() {
+		<-ch
+		canc()
+	}()
+
+	dev, err := device.CreateLora(ctx, params, cred)
 	if err != nil {
 		return err
 	}