Add support for compile_command.json output #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still very rough and unfinished.
Also slightly refactore code
cmaglie
force-pushed
the
compile_commands
branch
from
08eb89d to
a22edfa
Compare
silvanocerza
approved these changes
Dec 14, 2020
4 tasks
|
I finally gotten around to giving this code a whirl, seems to work nicely overall. There's still some points unsolved from #944, but let's further discuss them in #849. Why did you removing the "Writing compilation database..." message? IMHO it helps to both let people know that this feature is supported in the first place, and helps figure out where the file was written to, especially now it's only written to the build folder. In verbose mode, all commands run are printed, then why not show the compilation database was generated? |
Mainly because:
BTW, you have a good point, I'll put a message output on the caller side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is a tentative draft based on @matthijskooijman's #944
I've added a flag
--only-compilation-databaseflag incompilecommand. When this flag is specified the build run will perform only:sketch.ino.cppis saved in the usual${build_path}/sketch/...subdir)compile_command.json(saved in the build-path). In this case the sketch/core/libraries are not compiled but the command line is saved forcompile_command.json