Migrated TestVersion from test_main.py to main_test.go

Author: MatteoPologruto

internal/integrationtest/main/main_test.go

@@ -16,11 +16,13 @@
 package main_test
 
 import (
+	"encoding/json"
 	"testing"
 
 	"github.com/arduino/arduino-cli/internal/integrationtest"
 	"github.com/arduino/go-paths-helper"
 	"github.com/stretchr/testify/require"
+	semver "go.bug.st/relaxed-semver"
 	"go.bug.st/testsuite"
 )
 
@@ -39,3 +41,44 @@ func TestHelp(t *testing.T) {
 	require.Empty(t, stderr)
 	require.Contains(t, string(stdout), "Usage")
 }
+
+func TestVersion(t *testing.T) {
+	env := testsuite.NewEnvironment(t)
+	defer env.CleanUp()
+
+	cli := integrationtest.NewArduinoCliWithinEnvironment(env, &integrationtest.ArduinoCLIConfig{
+		ArduinoCLIPath:         paths.New("..", "..", "..", "arduino-cli"),
+		UseSharedStagingFolder: true,
+	})
+
+	// Run version and check the output message
+	stdout, stderr, err := cli.Run("version")
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Version:")
+	require.Contains(t, string(stdout), "Commit:")
+	require.Empty(t, stderr)
+
+	// Checks if "version --format json" has a json as an output
+	stdout, _, err = cli.Run("version", "--format", "json")
+	require.NoError(t, err)
+	var jsonMap map[string]string
+	err = json.Unmarshal(stdout, &jsonMap)
+	require.NoError(t, err)
+
+	// Checks if Application's value is arduino-cli
+	require.Equal(t, jsonMap["Application"], "arduino-cli")
+
+	// Checks if VersionString's value is git-snapshot, nightly or a valid semantic versioning
+	switch version := jsonMap["VersionString"]; version {
+	case "git-snapshot":
+		require.Contains(t, version, "git-snapshot")
+	case "nigthly":
+		require.Contains(t, version, "nightly")
+	default:
+		_, err = semver.Parse(version)
+		require.NoError(t, err)
+	}
+
+	// Checks if Commit's value is not empty
+	require.NotEmpty(t, jsonMap["Commit"])
+}

test/test_main.py

@@ -18,23 +18,6 @@
 import semver
 import yaml
 
-
-def test_version(run_command):
-    result = run_command(["version"])
-    assert result.ok
-    assert "Version:" in result.stdout
-    assert "Commit:" in result.stdout
-    assert "" == result.stderr
-
-    result = run_command(["version", "--format", "json"])
-    assert result.ok
-    parsed_out = json.loads(result.stdout)
-    assert parsed_out.get("Application", False) == "arduino-cli"
-    version = parsed_out.get("VersionString", False)
-    assert semver.VersionInfo.isvalid(version=version) or "git-snapshot" in version or "nightly" in version
-    assert isinstance(parsed_out.get("Commit", False), str)
-
-
 def test_log_options(run_command, data_dir):
     """
     using `version` as a test command