Skip to content

Commit b51a7dd

Browse files
Migrate TestRemoveOnUnsupportedKey from test_config.py to config_test.go
1 parent 7906d64 commit b51a7dd

File tree

2 files changed

+24
-25
lines changed

2 files changed

+24
-25
lines changed

internal/integrationtest/config/config_test.go

+24
Original file line numberDiff line numberDiff line change
@@ -468,3 +468,27 @@ func TestRemoveMultipleArguments(t *testing.T) {
468468
require.NoError(t, err)
469469
requirejson.Query(t, stdout, ".board_manager | .additional_urls", "[]")
470470
}
471+
472+
func TestRemoveOnUnsupportedKey(t *testing.T) {
473+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
474+
defer env.CleanUp()
475+
476+
// Create a config file
477+
_, _, err := cli.Run("config", "init", "--dest-dir", ".")
478+
require.NoError(t, err)
479+
480+
// Verifies default value
481+
stdout, _, err := cli.Run("config", "dump", "--format", "json")
482+
require.NoError(t, err)
483+
requirejson.Query(t, stdout, ".daemon | .port", "\"50051\"")
484+
485+
// Tries and fails to remove an item
486+
_, stderr, err := cli.Run("config", "remove", "daemon.port", "50051")
487+
require.Error(t, err)
488+
require.Contains(t, string(stderr), "The key 'daemon.port' is not a list of items, can't remove from it.\nMaybe use 'config delete'?")
489+
490+
// Verifies value is not changed
491+
stdout, _, err = cli.Run("config", "dump", "--format", "json")
492+
require.NoError(t, err)
493+
requirejson.Query(t, stdout, ".daemon | .port", "\"50051\"")
494+
}

test/test_config.py

-25
Original file line numberDiff line numberDiff line change
@@ -17,31 +17,6 @@
1717
import yaml
1818

1919

20-
def test_remove_on_unsupported_key(run_command):
21-
# Create a config file
22-
assert run_command(["config", "init", "--dest-dir", "."])
23-
24-
# Verifies default value
25-
result = run_command(["config", "dump", "--format", "json"])
26-
assert result.ok
27-
settings_json = json.loads(result.stdout)
28-
assert "50051" == settings_json["daemon"]["port"]
29-
30-
# Tries and fails to add a new item
31-
result = run_command(["config", "remove", "daemon.port", "50051"])
32-
assert result.failed
33-
assert (
34-
"The key 'daemon.port' is not a list of items, can't remove from it.\nMaybe use 'config delete'?"
35-
in result.stderr
36-
)
37-
38-
# Verifies value is not changed
39-
result = run_command(["config", "dump", "--format", "json"])
40-
assert result.ok
41-
settings_json = json.loads(result.stdout)
42-
assert "50051" == settings_json["daemon"]["port"]
43-
44-
4520
def test_set_slice_with_single_argument(run_command):
4621
# Create a config file
4722
assert run_command(["config", "init", "--dest-dir", "."])

0 commit comments

Comments
 (0)