Skip to content

Commit 15e2e04

Browse files
Migrated TestUpgradeUsingLibraryWithInvalidVersion from test_upgrade.py to upgrade_test.go
1 parent 8dc5c2c commit 15e2e04

File tree

2 files changed

+27
-22
lines changed

2 files changed

+27
-22
lines changed

internal/integrationtest/upgrade/upgrade_test.go

+27
Original file line numberDiff line numberDiff line change
@@ -60,3 +60,30 @@ func TestUpgrade(t *testing.T) {
6060
require.NoError(t, err)
6161
require.Equal(t, string(stdout), "\n")
6262
}
63+
64+
func TestUpgradeUsingLibraryWithInvalidVersion(t *testing.T) {
65+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
66+
defer env.CleanUp()
67+
68+
_, _, err := cli.Run("update")
69+
require.NoError(t, err)
70+
71+
// Install latest version of a library
72+
_, _, err = cli.Run("lib", "install", "WiFi101")
73+
require.NoError(t, err)
74+
75+
// Verifies library is not shown
76+
stdout, _, err := cli.Run("outdated")
77+
require.NoError(t, err)
78+
require.NotContains(t, string(stdout), "WiFi101")
79+
80+
// Changes the version of the currently installed library so that it's invalid
81+
libPath := cli.SketchbookDir().Join("libraries", "WiFi101", "library.properties")
82+
err = libPath.WriteFile([]byte("name=WiFi101\nversion=1.0001"))
83+
require.NoError(t, err)
84+
85+
// Verifies library gets upgraded
86+
stdout, _, err = cli.Run("upgrade")
87+
require.NoError(t, err)
88+
require.Contains(t, string(stdout), "WiFi101")
89+
}

test/test_upgrade.py

-22
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,6 @@
1616
from pathlib import Path
1717

1818

19-
def test_upgrade_using_library_with_invalid_version(run_command, data_dir):
20-
assert run_command(["update"])
21-
22-
# Install latest version of a library
23-
assert run_command(["lib", "install", "WiFi101"])
24-
25-
# Verifies library is not shown
26-
res = run_command(["outdated"])
27-
assert res.ok
28-
assert "WiFi101" not in res.stdout
29-
30-
# Changes the version of the currently installed library so that it's
31-
# invalid
32-
lib_path = Path(data_dir, "libraries", "WiFi101")
33-
Path(lib_path, "library.properties").write_text("name=WiFi101\nversion=1.0001")
34-
35-
# Verifies library gets upgraded
36-
res = run_command(["upgrade"])
37-
assert res.ok
38-
assert "WiFi101" in res.stdout
39-
40-
4119
def test_upgrade_unused_core_tools_are_removed(run_command, data_dir):
4220
assert run_command(["update"])
4321

0 commit comments

Comments
 (0)