From 1710f5193e7b55c8b2a8725c96859a10e73eb879 Mon Sep 17 00:00:00 2001 From: pennam Date: Thu, 13 Feb 2025 09:06:51 +0100 Subject: [PATCH 1/8] CNetIf: suppress unused variable warning in getBSSID dummy implementation --- libraries/lwIpWrapper/src/CNetIf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/lwIpWrapper/src/CNetIf.h b/libraries/lwIpWrapper/src/CNetIf.h index 9f8bd404..407501b7 100644 --- a/libraries/lwIpWrapper/src/CNetIf.h +++ b/libraries/lwIpWrapper/src/CNetIf.h @@ -215,7 +215,7 @@ class CNetIf { /* default dummy implementation because ethernet does not have that */ virtual const char* getSSID() { return nullptr; } - virtual uint8_t* getBSSID(uint8_t* bssid) { return nullptr; } + virtual uint8_t* getBSSID(uint8_t* bssid) { (void)bssid; return nullptr; } virtual int32_t getRSSI() { return 0; } virtual uint8_t getEncryptionType() { return 0; } From bb800ba347abad19651b62565bcc56eeff220158 Mon Sep 17 00:00:00 2001 From: pennam Date: Thu, 13 Feb 2025 09:11:04 +0100 Subject: [PATCH 2/8] CNetIf: remove unused static variable --- libraries/lwIpWrapper/src/CNetIf.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/libraries/lwIpWrapper/src/CNetIf.cpp b/libraries/lwIpWrapper/src/CNetIf.cpp index 86b02edc..134b613d 100644 --- a/libraries/lwIpWrapper/src/CNetIf.cpp +++ b/libraries/lwIpWrapper/src/CNetIf.cpp @@ -224,7 +224,6 @@ CNetIf* CLwipIf::get(NetIfType_t type, IPAddress _nm) { /* -------------------------------------------------------------------------- */ - static int id = 0; CNetIf* rv = nullptr; bool isStation = true; bool isEth = false; From 0603b0c5c692a7d5a55b7ccda172044181d52e0b Mon Sep 17 00:00:00 2001 From: pennam Date: Thu, 13 Feb 2025 09:18:33 +0100 Subject: [PATCH 3/8] CNetIf: fix ctor initializers order --- libraries/lwIpWrapper/src/CNetIf.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/lwIpWrapper/src/CNetIf.cpp b/libraries/lwIpWrapper/src/CNetIf.cpp index 134b613d..ee8b97a0 100644 --- a/libraries/lwIpWrapper/src/CNetIf.cpp +++ b/libraries/lwIpWrapper/src/CNetIf.cpp @@ -1024,11 +1024,11 @@ uint8_t CLwipIf::getEncryptionType(NetIfType_t type) /* -------------------------------------------------------------------------- */ CNetIf::CNetIf() - : dhcp_timeout(30000) + : id(0) + , dhcp_timeout(30000) + , dhcp_st(DHCP_IDLE_STATUS) , dhcp_started(false) , dhcp_acquired(false) - , id(0) - , dhcp_st(DHCP_IDLE_STATUS) , _dhcp_lease_state(DHCP_CHECK_NONE) { /* -------------------------------------------------------------------------- */ From 8b1513f802e23dea018ab1dba776f48a1e0d123d Mon Sep 17 00:00:00 2001 From: pennam Date: Thu, 13 Feb 2025 15:51:32 +0100 Subject: [PATCH 4/8] lwipClient: suppress unused variable warning --- libraries/lwIpWrapper/src/lwipClient.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/lwIpWrapper/src/lwipClient.cpp b/libraries/lwIpWrapper/src/lwipClient.cpp index 745f4d50..9172db35 100644 --- a/libraries/lwIpWrapper/src/lwipClient.cpp +++ b/libraries/lwIpWrapper/src/lwipClient.cpp @@ -19,6 +19,7 @@ sketches but sock is ignored. */ lwipClient::lwipClient(uint8_t sock) : _tcp_client(NULL) { + (void)sock; } /* -------------------------------------------------------------------------- */ From ee4551305c841b0ace0f5225b2c5934638daa8cf Mon Sep 17 00:00:00 2001 From: pennam Date: Thu, 13 Feb 2025 16:15:51 +0100 Subject: [PATCH 5/8] lwipDhcpServer: delete unused variables --- libraries/lwIpWrapper/src/lwipDhcpServer.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/libraries/lwIpWrapper/src/lwipDhcpServer.c b/libraries/lwIpWrapper/src/lwipDhcpServer.c index 9589c284..e68edfa4 100644 --- a/libraries/lwIpWrapper/src/lwipDhcpServer.c +++ b/libraries/lwIpWrapper/src/lwipDhcpServer.c @@ -74,13 +74,6 @@ static struct netif *dhcps_netif = NULL; static struct udp_pcb *dhcps_pcb; static DHCP_Address dhcp_address; - -static uint8_t xid[4]; - - -//static list_node *plist = NULL; -static bool renew = false; - static dhcps_lease_t dhcps_poll; static dhcps_time_t dhcps_lease_time = DHCPS_LEASE_TIME_DEF; //minute static dhcps_offer_t dhcps_offer = 0xFF; @@ -350,9 +343,7 @@ static void send_offer(struct dhcps_msg *msg, uint16_t len) struct pbuf *p, *q; uint8_t *data; uint16_t cnt = 0; - uint8_t CopyFinished=0; uint16_t i; - uint32_t endptr , dataptr = NULL; #if DHCPS_DEBUG err_t SendOffer_err_t; #endif @@ -666,8 +657,6 @@ static void handle_dhcp(void *arg, { struct dhcps_msg *pmsg_dhcps = NULL; int16_t tlen, malloc_len; - uint16_t i; - uint16_t dhcps_msg_cnt = 0; uint8_t *p_dhcps_msg = NULL; struct pbuf *q; From da684a43d73be24503039d7197151979d7b5859c Mon Sep 17 00:00:00 2001 From: pennam Date: Thu, 13 Feb 2025 16:17:13 +0100 Subject: [PATCH 6/8] lwipDhcpServer: avoid redefinitions --- libraries/lwIpWrapper/src/lwipDhcpServer.c | 52 +++++----------------- 1 file changed, 12 insertions(+), 40 deletions(-) diff --git a/libraries/lwIpWrapper/src/lwipDhcpServer.c b/libraries/lwIpWrapper/src/lwipDhcpServer.c index e68edfa4..dc00d3cc 100644 --- a/libraries/lwIpWrapper/src/lwipDhcpServer.c +++ b/libraries/lwIpWrapper/src/lwipDhcpServer.c @@ -1,8 +1,5 @@ #include #include - - - #include "lwipDhcpServer.h" #include "lwipDhcpServerPriv.h" @@ -11,37 +8,12 @@ static const u32_t magic_cookie = 0x63538263; #define BOOTP_BROADCAST 0x8000 -#define DHCP_REQUEST 1 -#define DHCP_REPLY 2 #define DHCP_HTYPE_ETHERNET 1 -#define DHCP_HLEN_ETHERNET 6 -#define DHCP_MSG_LEN 236 #define DHCPS_SERVER_PORT 67 #define DHCPS_CLIENT_PORT 68 -#define DHCPDISCOVER 1 -#define DHCPOFFER 2 -#define DHCPREQUEST 3 -#define DHCPDECLINE 4 -#define DHCPACK 5 -#define DHCPNAK 6 -#define DHCPRELEASE 7 - -#define DHCP_OPTION_SUBNET_MASK 1 -#define DHCP_OPTION_ROUTER 3 -#define DHCP_OPTION_DNS_SERVER 6 -#define DHCP_OPTION_REQ_IPADDR 50 -#define DHCP_OPTION_LEASE_TIME 51 -#define DHCP_OPTION_MSG_TYPE 53 -#define DHCP_OPTION_SERVER_ID 54 -#define DHCP_OPTION_INTERFACE_MTU 26 #define DHCP_OPTION_PERFORM_ROUTER_DISCOVERY 31 -#define DHCP_OPTION_BROADCAST_ADDRESS 28 -#define DHCP_OPTION_REQ_LIST 55 -#define DHCP_OPTION_END 255 - - #ifdef DHCPS_DEBUG /* function defined in CNetIf.cpp */ @@ -184,7 +156,7 @@ void dhcps_set_option_info(uint8_t op_id, void *opt_info, u32_t opt_len) *******************************************************************************/ static uint8_t *add_msg_type(uint8_t *optptr, uint8_t type) { - *optptr++ = DHCP_OPTION_MSG_TYPE; + *optptr++ = DHCP_OPTION_MESSAGE_TYPE; *optptr++ = 1; *optptr++ = type; return optptr; @@ -253,7 +225,7 @@ static uint8_t *add_offer_options(uint8_t *optptr) } - *optptr++ = DHCP_OPTION_INTERFACE_MTU; + *optptr++ = DHCP_OPTION_MTU; *optptr++ = 2; *optptr++ = 0x05; *optptr++ = 0xdc; @@ -294,7 +266,7 @@ static uint8_t *add_end(uint8_t *optptr) *******************************************************************************/ static void create_msg(struct dhcps_msg *m) { - m->op = DHCP_REPLY; + m->op = DHCP_BOOTREPLY; m->htype = DHCP_HTYPE_ETHERNET; @@ -348,7 +320,7 @@ static void send_offer(struct dhcps_msg *msg, uint16_t len) err_t SendOffer_err_t; #endif create_msg(msg); - end = add_msg_type(&msg->options[4], DHCPOFFER); + end = add_msg_type(&msg->options[4], DHCP_OFFER); end = add_offer_options(end); end = add_end(end); @@ -418,7 +390,7 @@ static void send_nak(struct dhcps_msg *m, uint16_t len) #endif create_msg(m); - end = add_msg_type(&m->options[4], DHCPNAK); + end = add_msg_type(&m->options[4], DHCP_NAK); end = add_end(end); p = dhcps_pbuf_alloc(len); @@ -482,7 +454,7 @@ static void send_ack(struct dhcps_msg *m, uint16_t len) err_t SendAck_err_t; create_msg(m); - end = add_msg_type(&m->options[4], DHCPACK); + end = add_msg_type(&m->options[4], DHCP_ACK); end = add_offer_options(end); end = add_end(end); @@ -564,10 +536,10 @@ static uint8_t parse_options(uint8_t *OptionsPtr, int16_t len) DHCPS_LOG("dhcps: (int16_t)*optptr = %d\n", (int16_t)*OptionsPtr); #endif switch ((int16_t) *OptionsPtr) { - case DHCP_OPTION_MSG_TYPE: //53 + case DHCP_OPTION_MESSAGE_TYPE://53 type = *(OptionsPtr + 2); break; - case DHCP_OPTION_REQ_IPADDR://50 + case DHCP_OPTION_REQUESTED_IP://50 s.state = DHCPS_STATE_ACK; break; case DHCP_OPTION_END: { @@ -583,26 +555,26 @@ static uint8_t parse_options(uint8_t *OptionsPtr, int16_t len) } switch (type) { - case DHCPDISCOVER://1 + case DHCP_DISCOVER://1 #if DHCPS_DEBUG DHCPS_LOG("dhcps: DHCPD_STATE_DHCPDISCOVER -- SEND_OFFER\n"); #endif s.state = DHCPS_STATE_OFFER; break; - case DHCPREQUEST://3 + case DHCP_REQUEST://3 #if DHCPS_DEBUG DHCPS_LOG("dhcps: DHCPD_STATE_DHCPREQUEST -- SEND_ACK\n"); #endif s.state = DHCPS_STATE_ACK; break; - case DHCPDECLINE://4 + case DHCP_DECLINE://4 s.state = DHCPS_STATE_IDLE; #if DHCPS_DEBUG DHCPS_LOG("dhcps: DHCPD_STATE_IDLE\n"); #endif break; - case DHCPRELEASE://7 + case DHCP_RELEASE://7 s.state = DHCPS_STATE_RELEASE; #if DHCPS_DEBUG DHCPS_LOG("dhcps: DHCPD_STATE_IDLE\n"); From 6c3359f4e0bf81075834977026acbf70d64925d1 Mon Sep 17 00:00:00 2001 From: pennam Date: Thu, 13 Feb 2025 16:18:37 +0100 Subject: [PATCH 7/8] lwipDhcpServer: suppress unused variable warning --- libraries/lwIpWrapper/src/lwipDhcpServer.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libraries/lwIpWrapper/src/lwipDhcpServer.c b/libraries/lwIpWrapper/src/lwipDhcpServer.c index dc00d3cc..64f6846a 100644 --- a/libraries/lwIpWrapper/src/lwipDhcpServer.c +++ b/libraries/lwIpWrapper/src/lwipDhcpServer.c @@ -311,6 +311,7 @@ struct pbuf * dhcps_pbuf_alloc(uint16_t len) *******************************************************************************/ static void send_offer(struct dhcps_msg *msg, uint16_t len) { + (void)len; uint8_t *end; struct pbuf *p, *q; uint8_t *data; @@ -380,6 +381,7 @@ static void send_offer(struct dhcps_msg *msg, uint16_t len) *******************************************************************************/ static void send_nak(struct dhcps_msg *m, uint16_t len) { + (void)len; uint8_t *end; struct pbuf *p, *q; uint8_t *data; @@ -446,6 +448,7 @@ static void send_nak(struct dhcps_msg *m, uint16_t len) *******************************************************************************/ static void send_ack(struct dhcps_msg *m, uint16_t len) { + (void)len; uint8_t *end; struct pbuf *p, *q; uint8_t *data; @@ -627,6 +630,10 @@ static void handle_dhcp(void *arg, const ip_addr_t *addr, uint16_t port) { + (void)arg; + (void)pcb; + (void)addr; + (void)port; struct dhcps_msg *pmsg_dhcps = NULL; int16_t tlen, malloc_len; uint8_t *p_dhcps_msg = NULL; From fb2c94ad3b26c0f949a984a404b010f7ad3398d0 Mon Sep 17 00:00:00 2001 From: pennam Date: Thu, 13 Feb 2025 17:09:47 +0100 Subject: [PATCH 8/8] CNetIf: fix limited variable range warning --- libraries/lwIpWrapper/src/CNetIf.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/lwIpWrapper/src/CNetIf.cpp b/libraries/lwIpWrapper/src/CNetIf.cpp index ee8b97a0..810b1407 100644 --- a/libraries/lwIpWrapper/src/CNetIf.cpp +++ b/libraries/lwIpWrapper/src/CNetIf.cpp @@ -228,7 +228,7 @@ CNetIf* CLwipIf::get(NetIfType_t type, bool isStation = true; bool isEth = false; - if (type >= 0 && type < NETWORK_INTERFACES_MAX_NUM) { + if (type == NI_WIFI_STATION || type == NI_WIFI_SOFTAP || type == NI_ETHERNET) { if (net_ifs[type] == nullptr) { switch (type) { case NI_WIFI_STATION: