Skip to content

analog: wrong setting for 12bit #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhwcat opened this issue Feb 19, 2025 · 0 comments · Fixed by #448
Closed

analog: wrong setting for 12bit #446

dhwcat opened this issue Feb 19, 2025 · 0 comments · Fixed by #448
Assignees
@pennam
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@dhwcat
Copy link

dhwcat commented Feb 19, 2025 •
edited by per1234
Loading

This is likely a typo:

ArduinoCore-renesas/cores/arduino/analog.cpp

Line 648 in e7ed91b

adc1.cfg.resolution = ADC_RESOLUTION_10_BIT;

@pennam pennam self-assigned this Feb 19, 2025
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Feb 19, 2025
@pennam pennam mentioned this issue Feb 24, 2025
Merged
@per1234 per1234 added the conclusion: resolved Issue was resolved label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pennam pennam

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adc: analogReadResolution fix adc1 resolution pennam/ArduinoCore-renesas
3 participants
@per1234 @pennam @dhwcat