Merge pull request #841 from trik/ethernet_begin_fix

facchinm · web-flow · commit 321c2fbac9c7 · 2024-02-14T18:07:14.000+01:00
fix(Ethernet): missing return statement in begin with mac, timeout and responseTimeout
diff --git a/libraries/Ethernet/src/Ethernet.cpp b/libraries/Ethernet/src/Ethernet.cpp
@@ -9,7 +9,7 @@ int arduino::EthernetClass::begin(uint8_t *mac, unsigned long timeout, unsigned
     if (eth_if == nullptr) return 0;
   }
   eth_if->set_dhcp(true);
-  _begin(mac, timeout, responseTimeout);
+  return _begin(mac, timeout, responseTimeout);
 }
 
 int arduino::EthernetClass::_begin(uint8_t *mac, unsigned long timeout, unsigned long responseTimeout) {

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ int arduino::EthernetClass::begin(uint8_t *mac, unsigned long timeout, unsigned`
`9`	`9`	`if (eth_if == nullptr) return 0;`
`10`	`10`	`}`
`11`	`11`	`eth_if->set_dhcp(true);`
`12`		`- _begin(mac, timeout, responseTimeout);`
	`12`	`+ return _begin(mac, timeout, responseTimeout);`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`int arduino::EthernetClass::_begin(uint8_t *mac, unsigned long timeout, unsigned long responseTimeout) {`