Added bounds checking on pinMode

BarryPSmith · BarryPSmith · commit 3122511e4594 · 2019-11-30T13:41:17.000-08:00
diff --git a/cores/arduino/wiring_digital.c b/cores/arduino/wiring_digital.c
@@ -28,6 +28,9 @@
 
 void pinMode(uint8_t pin, uint8_t mode)
 {
+  //prevent reading beyond end of arrays:
+  if (pin > sizeof(digital_pin_to_port_PGM) / sizeof(digital_pin_to_port_PGM[0])) return;
+
 	uint8_t bit = digitalPinToBitMask(pin);
 	uint8_t port = digitalPinToPort(pin);
 	volatile uint8_t *reg, *out;

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@`
`28`	`28`
`29`	`29`	`void pinMode(uint8_t pin, uint8_t mode)`
`30`	`30`	`{`
	`31`	`+ //prevent reading beyond end of arrays:`
	`32`	`+ if (pin > sizeof(digital_pin_to_port_PGM) / sizeof(digital_pin_to_port_PGM[0])) return;`
	`33`	`+`
`31`	`34`	`uint8_t bit = digitalPinToBitMask(pin);`
`32`	`35`	`uint8_t port = digitalPinToPort(pin);`
`33`	`36`	`volatile uint8_t reg, out;`