Skip to content

Commit d02e908

Browse files
Fede85cmaglie
authored andcommitted
Removed redundant TX and RX buffer size initialization. Default value is already 2kB
1 parent 699556a commit d02e908

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

libraries/Ethernet/src/utility/w5100.cpp

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,11 @@ void W5x00Class::init(void)
7676
SPI.endTransaction();
7777

7878
// W5x00 reset
79+
// The default size for the RX and TX buffers is 2 kB
7980
if (chipset == W5x00Chipset::W5100) {
8081
sockets = 4;
8182
SPI.beginTransaction(SPI_ETHERNET_SETTINGS);
8283
writeMR(1<<RST);
83-
writeTMSR(0x55);
84-
writeRMSR(0x55);
8584
SPI.endTransaction();
8685

8786
const uint16_t TXBUF_BASE = 0x4000;
@@ -94,10 +93,6 @@ void W5x00Class::init(void)
9493
sockets = 8;
9594
SPI.beginTransaction(SPI_ETHERNET_SETTINGS);
9695
writeMR(1<<RST);
97-
for (uint8_t i=0; i<sockets; i++) {
98-
writeSnRXBUF_SIZE(i, 2);
99-
writeSnTXBUF_SIZE(i, 2);
100-
}
10196
SPI.endTransaction();
10297

10398
const uint16_t TXBUF_BASE = 0x8000;
@@ -110,10 +105,6 @@ void W5x00Class::init(void)
110105
sockets = 8;
111106
SPI.beginTransaction(SPI_ETHERNET_SETTINGS);
112107
writeMR(1<<RST);
113-
for (uint8_t i=0; i<sockets; i++) {
114-
writeSnRXBUF_SIZE(i, 2);
115-
writeSnTXBUF_SIZE(i, 2);
116-
}
117108
SPI.endTransaction();
118109
}
119110
}

0 commit comments

Comments
 (0)