Change workaround for ctrl-slash handling in RSyntaxTextArea

Previously, there was a handler on the text area that consumed most
KEY_TYPED events with control pressed. This was added a long time ago to
fix a problem with ctrl-slash doing both the toggle comment action and
inserting a /. Further investigation shows that with RSyntaxTextArea
this problem is still present, but is caused by a weird binding on the
slash key that Arduino is not even using. Removing that binding is a
cleaner workaround for this problem, so this commit switches to that
workaround.

Ideally this would be fixed in RSyntaxTextArea, see
bobbylight/RSyntaxTextArea#157

Author: matthijskooijman

app/src/processing/app/EditorListener.java

@@ -22,14 +22,6 @@ public EditorListener(Editor editor) {
   private static final int CTRL_SHIFT = InputEvent.SHIFT_MASK | CTRL;
 
   public void keyTyped(KeyEvent event) {
-    char c = event.getKeyChar();
-
-    if ((event.getModifiers() & KeyEvent.CTRL_MASK) != 0) {
-      // The char is not control code when CTRL key pressed? It should be a shortcut.
-      if (!Character.isISOControl(c)) {
-        event.consume();
-      }
-    }
   }
 
   @Override

app/src/processing/app/syntax/SketchTextArea.java

@@ -40,7 +40,9 @@
 import processing.app.BaseNoGui;
 import processing.app.EditorListener;
 import processing.app.PreferencesData;
+import processing.app.helpers.Keys;
 
+import javax.swing.KeyStroke;
 import javax.swing.event.EventListenerList;
 import javax.swing.event.HyperlinkEvent;
 import javax.swing.event.HyperlinkListener;

app/src/processing/app/syntax/SketchTextAreaDefaultInputMap.java

@@ -5,6 +5,7 @@
 import org.fife.ui.rtextarea.RTextArea;
 import org.fife.ui.rtextarea.RTextAreaEditorKit;
 import processing.app.PreferencesData;
+import processing.app.helpers.Keys;
 
 import javax.swing.*;
 import javax.swing.text.DefaultEditorKit;
@@ -23,6 +24,15 @@ public SketchTextAreaDefaultInputMap() {
 
     remove(KeyStroke.getKeyStroke(KeyEvent.VK_K, defaultModifier));
 
+    // Remove a troublesome binding for the / key. By default, RSyntaxTextArea
+    // binds the / KEY_TYPED event to insert a / and optionally complete any XML
+    // tags. However, since this also triggeres on ctrl-slash, this means that
+    // in addition to toggling comments on ctrl-slash, it also inserts a slash.
+    // Since we don't need the XML completion feature anyway, just unbind it
+    // here. A future version of RSyntaxTextArea might fix this, see
+    // https://github.com/bobbylight/RSyntaxTextArea/issues/157.
+    remove(KeyStroke.getKeyStroke('/'));
+
     if (PreferencesData.getBoolean("editor.advanced")) {
       put(KeyStroke.getKeyStroke(KeyEvent.VK_DOWN, alt), RTextAreaEditorKit.rtaLineDownAction);
       put(KeyStroke.getKeyStroke(KeyEvent.VK_UP, alt), RTextAreaEditorKit.rtaLineUpAction);