Skip to content

feat(cli): Capture some basic information during the update check #8732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owenrumney opened this issue Apr 14, 2025 · 0 comments · May be fixed by #8553
Open

feat(cli): Capture some basic information during the update check #8732

owenrumney opened this issue Apr 14, 2025 · 0 comments · May be fixed by #8553
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@owenrumney
Copy link
Member

Discussed in #8675

Originally posted by itaysk April 3, 2025

Description

Trivy has grown to be a serious product, and we need to start managing it like a product. One pillar of product management is understanding the usage patterns, user personas and use cases. Being data driven and results oriented is key to growth, and for that we need data.

This is a proposal for how it might look like:

Metrics

facts:

  • count of scans
  • count of errors

dimensions:

  • platform (os,arch)
  • trivy version
  • db version
  • features (flags)
  • user id

PII

Every input that is user-controlled is considered PII and will not be collected. For example:

trivy image --severity HIGH --ignoefile ./secretcorp/trivyignore.yaml secretapp

part private?
image No
--severity No
HIGH No
--ignorefile No
./secretcorp/trivyignore.yaml Yes
secretapp Yes

User ID

for authenticated users - the use identity
for unauthenticated users - random identifier generated from a one way hash of mac address

Impact

no impact on scan time
no impact on output
easy opt out using a flag/config/envvar
if network is unavailable, try to save to disk (cache) (log rotation)

Implementation suggestion

We had a tangential discussion about a checking for updates. It would make sense to combine the two features into a single request. When Trivy checks for updates, we can capture the necessary information as part of the netwrok request.

@owenrumney owenrumney added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 14, 2025
@owenrumney owenrumney linked a pull request Apr 14, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant