fix: update set_dev_version.py and fix minimum clearance line unit test #330
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI build was failing because set_dev_version.py only updated the workspace package version to include the -alphaN suffix, but didn't update the workspace dependencies versions. This caused Cargo to fail with version mismatch errors like: error: failed to select a version for the requirement `sedona-expr = "^0.2.0"` candidate versions found which didn't match: 0.2.0-alpha87 This fix updates the script to also replace version numbers in the workspace dependencies section, ensuring they match the prerelease version (e.g., "0.2.0-alpha390").
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI build failures caused by version mismatches in Cargo.toml when setting development versions. The script now updates both the workspace package version and workspace dependencies versions to include the alpha prerelease suffix, ensuring consistency across the configuration.
Key changes:
- Added logic to update workspace dependencies versions with the alpha suffix
- Added comments to clarify the purpose of each version update section
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Add blank line to workflow file to trigger CI build and test the set_dev_version.py fix. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…to chore/fix.python.wheel.build
…rance line unambiguous
zhangfengcdt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI build was failing because set_dev_version.py only updated the workspace package version to include the -alphaN suffix, but didn't update the workspace dependencies versions. This caused Cargo to fail with version mismatch errors like:
This fix updates the script to also replace version numbers in the workspace dependencies section, ensuring they match the prerelease version (e.g., "0.2.0-alpha390").
In addition, the PR also fix a python test to make the expected minimum clearance line unambiguous.
The fourth triangle's vertices changed from (2.5 2.5, 3 3, 3 2) to (2.5 2.5, 3.5 3.5, 3.5 1.5), moving the right edge further away: