Skip to content

Commit 5d63451

Browse files
authored
refactor(bindings/node)!: Change is_exist to exists to align with nodejs API style (#5731)
* chore: node binding is_exist to exists and fix audit Signed-off-by: yihong0618 <[email protected]> * fix: use pnpm instead of npm Signed-off-by: yihong0618 <[email protected]> * fix: change back generated.d.ts address comments Signed-off-by: yihong0618 <[email protected]> * chore: update the upgrade breaking change Signed-off-by: yihong0618 <[email protected]> * fix: lint things Signed-off-by: yihong0618 <[email protected]> * fix: make node binding version right Signed-off-by: yihong0618 <[email protected]> --------- Signed-off-by: yihong0618 <[email protected]>
1 parent 3cfce47 commit 5d63451

File tree

5 files changed

+157
-308
lines changed

5 files changed

+157
-308
lines changed

bindings/nodejs/generated.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ export class Operator {
252252
* await op.isExist("test");
253253
* ```
254254
*/
255-
isExist(path: string): Promise<boolean>
255+
exists(path: string): Promise<boolean>
256256
/**
257257
* Check if this path exists or not synchronously.
258258
*
@@ -261,7 +261,7 @@ export class Operator {
261261
* op.isExistSync("test");
262262
* ```
263263
*/
264-
isExistSync(path: string): boolean
264+
existsSync(path: string): boolean
265265
/**
266266
* Create dir with a given path.
267267
*

bindings/nodejs/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"prettier": "^2.8.4",
5959
"typedoc": "^0.25",
6060
"typescript": "^5.0.2",
61-
"vitest": "^1.6.0"
61+
"vitest": "^3.0.8"
6262
},
6363
"engines": {
6464
"node": ">= 10"

0 commit comments

Comments
 (0)