[MNG-6847] Use diamond operator (#327)

As discussed on
- apache/maven-scm#184
- https://issues.apache.org/jira/browse/MNG-6847

Review requested of @elharo

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu

Co-authored-by: Moderne <[email protected]>

Author: timtebeek

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java

@@ -418,8 +418,7 @@ public List<RemoteRepository> newResolutionRepositories(
         validateSession(session);
         validateRepositories(repositories);
 
-        repositories = remoteRepositoryManager.aggregateRepositories(
-                session, new ArrayList<RemoteRepository>(), repositories, true);
+        repositories = remoteRepositoryManager.aggregateRepositories(session, new ArrayList<>(), repositories, true);
         return repositories;
     }
 

maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/StubFileTransformerManager.java

@@ -37,7 +37,7 @@ public Collection<FileTransformer> getTransformersForArtifact(Artifact artifact)
 
     public void addFileTransformer(String extension, FileTransformer fileTransformer) {
         if (!fileTransformers.containsKey(extension)) {
-            fileTransformers.put(extension, new HashSet<FileTransformer>());
+            fileTransformers.put(extension, new HashSet<>());
         }
         fileTransformers.get(extension).add(fileTransformer);
     }

maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/IniArtifactDataReader.java

@@ -118,7 +118,7 @@ private ArtifactDescription parse(Reader reader) throws IOException {
                         String name = line.substring(1, line.length() - 1);
                         name = name.replace("-", "").toUpperCase(Locale.ENGLISH);
                         state = State.valueOf(name);
-                        sections.put(state, new ArrayList<String>());
+                        sections.put(state, new ArrayList<>());
                     } catch (IllegalArgumentException e) {
                         throw new IOException("unknown section: " + line);
                     }

maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpServer.java

@@ -113,7 +113,7 @@ public enum ChecksumHeader {
 
     private final AtomicInteger connectionsToClose = new AtomicInteger(0);
 
-    private List<LogEntry> logEntries = Collections.synchronizedList(new ArrayList<LogEntry>());
+    private List<LogEntry> logEntries = Collections.synchronizedList(new ArrayList<>());
 
     public String getHost() {
         return "localhost";

maven-resolver-util/src/test/java/org/eclipse/aether/util/filter/PatternExclusionsDependencyFilterTest.java

@@ -177,11 +177,11 @@ public void acceptTestRange() {
     }
 
     private boolean dontAccept(DependencyNode node, String expression) {
-        return !new PatternExclusionsDependencyFilter(expression).accept(node, new LinkedList<DependencyNode>());
+        return !new PatternExclusionsDependencyFilter(expression).accept(node, new LinkedList<>());
     }
 
     private boolean dontAcceptVersionRange(DependencyNode node, String... expression) {
         return !new PatternExclusionsDependencyFilter(new GenericVersionScheme(), expression)
-                .accept(node, new LinkedList<DependencyNode>());
+                .accept(node, new LinkedList<>());
     }
 }

maven-resolver-util/src/test/java/org/eclipse/aether/util/filter/PatternInclusionsDependencyFilterTest.java

@@ -169,11 +169,11 @@ public void acceptTestRange() {
     }
 
     public boolean accept(DependencyNode node, String expression) {
-        return new PatternInclusionsDependencyFilter(expression).accept(node, new LinkedList<DependencyNode>());
+        return new PatternInclusionsDependencyFilter(expression).accept(node, new LinkedList<>());
     }
 
     public boolean acceptVersionRange(DependencyNode node, String... expression) {
         return new PatternInclusionsDependencyFilter(new GenericVersionScheme(), expression)
-                .accept(node, new LinkedList<DependencyNode>());
+                .accept(node, new LinkedList<>());
     }
 }