From 45d2417875a20a77e98032ef8d04a6524b53a470 Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Mon, 21 Jul 2025 22:46:54 -0700 Subject: [PATCH 1/2] use toml-cli --- .github/workflows/release_python.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release_python.yml b/.github/workflows/release_python.yml index 170869419d..2ce31d01aa 100644 --- a/.github/workflows/release_python.yml +++ b/.github/workflows/release_python.yml @@ -87,16 +87,17 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Install cargo-edit + - name: Install toml-cli if: ${{ needs.validate-release-tag.outputs.is-rc == 'true' }} - run: cargo install cargo-edit + run: cargo install toml-cli - name: Set cargo version for RC if: ${{ needs.validate-release-tag.outputs.is-rc == 'true' }} working-directory: "bindings/python" run: | echo "Setting cargo version to: ${{ needs.validate-release-tag.outputs.cargo-version }}" - cargo set-version ${{ needs.validate-release-tag.outputs.cargo-version }} + toml set Cargo.toml package.version ${{ needs.validate-release-tag.outputs.cargo-version }} > Cargo.toml.tmp + mv Cargo.toml.tmp Cargo.toml - uses: PyO3/maturin-action@v1 with: @@ -127,16 +128,17 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Install cargo-edit + - name: Install toml-cli if: ${{ needs.validate-release-tag.outputs.is-rc == 'true' }} - run: cargo install cargo-edit + run: cargo install toml-cli - name: Set cargo version for RC if: ${{ needs.validate-release-tag.outputs.is-rc == 'true' }} working-directory: "bindings/python" run: | echo "Setting cargo version to: ${{ needs.validate-release-tag.outputs.cargo-version }}" - cargo set-version ${{ needs.validate-release-tag.outputs.cargo-version }} + toml set Cargo.toml package.version ${{ needs.validate-release-tag.outputs.cargo-version }} > Cargo.toml.tmp + mv Cargo.toml.tmp Cargo.toml - uses: actions/setup-python@v5 with: From 6df5671f8232051ba10f80b2d1a0ca2e4da2e73d Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Mon, 21 Jul 2025 23:00:32 -0700 Subject: [PATCH 2/2] fix mv --- .github/workflows/release_python.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/release_python.yml b/.github/workflows/release_python.yml index 2ce31d01aa..ca98de1a7a 100644 --- a/.github/workflows/release_python.yml +++ b/.github/workflows/release_python.yml @@ -97,6 +97,8 @@ jobs: run: | echo "Setting cargo version to: ${{ needs.validate-release-tag.outputs.cargo-version }}" toml set Cargo.toml package.version ${{ needs.validate-release-tag.outputs.cargo-version }} > Cargo.toml.tmp + # doing this explicitly to avoid issue in Windows where `mv` does not overwrite existing file + rm Cargo.toml mv Cargo.toml.tmp Cargo.toml - uses: PyO3/maturin-action@v1 @@ -138,6 +140,8 @@ jobs: run: | echo "Setting cargo version to: ${{ needs.validate-release-tag.outputs.cargo-version }}" toml set Cargo.toml package.version ${{ needs.validate-release-tag.outputs.cargo-version }} > Cargo.toml.tmp + # doing this explicitly to avoid issue in Windows where `mv` does not overwrite existing file + rm Cargo.toml mv Cargo.toml.tmp Cargo.toml - uses: actions/setup-python@v5