Skip to content

Conversation

@ajayydv
Copy link
Contributor

@ajayydv ajayydv commented Jun 6, 2019

No description provided.

@ajayydv ajayydv requested review from anuengineer and xiaoyuyao June 6, 2019 16:12
@ajayydv ajayydv added the ozone label Jun 6, 2019
@ajayydv ajayydv self-assigned this Jun 6, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 33 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 505 trunk passed
+1 compile 301 trunk passed
+1 checkstyle 88 trunk passed
+1 mvnsite 0 trunk passed
-1 shadedclient 170 branch has errors when building and testing our client artifacts.
+1 javadoc 174 trunk passed
0 spotbugs 331 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 518 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 454 the patch passed
+1 compile 299 the patch passed
+1 cc 299 the patch passed
+1 javac 299 the patch passed
-0 checkstyle 44 hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedclient 61 patch has errors when building and testing our client artifacts.
+1 javadoc 173 the patch passed
+1 findbugs 533 the patch passed
_ Other Tests _
+1 unit 239 hadoop-hdds in the patch passed.
-1 unit 1375 hadoop-ozone in the patch failed.
+1 asflicense 53 The patch does not generate ASF License warnings.
5292
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestFailureHandlingByClient
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-920/1/artifact/out/Dockerfile
GITHUB PR #920
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 2118b4f00262 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 36757ad
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-920/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-920/1/testReport/
Max. process+thread count 4915 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/dist U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-920/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Test Bucket Acls
[arguments] ${protocol} ${server} ${volume}
${result} = Execute ozone sh volume getacl ${protocol}${server}/${volume}/bb1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be ozone sh bucket


Test key Acls
[arguments] ${protocol} ${server} ${volume}
${result} = Execute ozone sh volume getacl ${protocol}${server}/${volume}/bb1/key1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be ozone sh key

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 45 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 517 trunk passed
+1 compile 289 trunk passed
+1 checkstyle 84 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 935 branch has no errors when building and testing our client artifacts.
+1 javadoc 179 trunk passed
0 spotbugs 217 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 91 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
0 mvndep 21 Maven dependency ordering for patch
+1 mvninstall 472 the patch passed
+1 compile 294 the patch passed
+1 cc 294 the patch passed
+1 javac 294 the patch passed
-0 checkstyle 43 hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 727 patch has no errors when building and testing our client artifacts.
+1 javadoc 170 the patch passed
+1 findbugs 548 the patch passed
_ Other Tests _
-1 unit 169 hadoop-hdds in the patch failed.
-1 unit 1943 hadoop-ozone in the patch failed.
+1 asflicense 49 The patch does not generate ASF License warnings.
6992
Reason Tests
Failed junit tests hadoop.ozone.container.common.impl.TestHddsDispatcher
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestBCSID
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-920/2/artifact/out/Dockerfile
GITHUB PR #920
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 4b4e8cd9a1e5 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cb9bc6e
Default Java 1.8.0_212
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-920/2/artifact/out/branch-findbugs-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-920/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-920/2/testReport/
Max. process+thread count 5283 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/dist hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-920/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
0 mvndep 43 Maven dependency ordering for branch
+1 mvninstall 511 trunk passed
+1 compile 312 trunk passed
+1 checkstyle 94 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 900 branch has no errors when building and testing our client artifacts.
+1 javadoc 192 trunk passed
0 spotbugs 396 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 585 trunk passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 457 the patch passed
+1 compile 296 the patch passed
+1 cc 296 the patch passed
+1 javac 296 the patch passed
-0 checkstyle 50 hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 686 patch has no errors when building and testing our client artifacts.
+1 javadoc 177 the patch passed
+1 findbugs 539 the patch passed
_ Other Tests _
-1 unit 159 hadoop-hdds in the patch failed.
-1 unit 1029 hadoop-ozone in the patch failed.
+1 asflicense 60 The patch does not generate ASF License warnings.
6358
Reason Tests
Failed junit tests hadoop.ozone.container.common.impl.TestHddsDispatcher
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-920/3/artifact/out/Dockerfile
GITHUB PR #920
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 6c92a8374f83 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 76b94c2
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-920/3/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/3/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-920/3/testReport/
Max. process+thread count 5011 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/dist hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-920/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


@CommandLine.Option(names = {"--acl", "-a"},
required = true,
description = "new acl." +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acl to be removed. instead of new acl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

OzoneAcl.parseAcl(acl));

System.out.printf("%s%n", JsonUtils.toJsonStringWithDefaultPrettyPrinter(
JsonUtils.toJsonString("Acl set successfully: " + result)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed instead of set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

*/
@Override
public Void call() throws Exception {
Objects.requireNonNull(acls, "New acls to be added not specified.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acls to be set not specified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

import static org.apache.hadoop.ozone.security.acl.OzoneObj.StoreType.OZONE;

/**
* Executes Info bucket.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Executes Info bucket" does not match the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

import static org.apache.hadoop.ozone.security.acl.OzoneObj.StoreType.OZONE;

/**
* Executes Info bucket.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good to me. Just a few minor comments.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0 mvndep 46 Maven dependency ordering for branch
+1 mvninstall 520 trunk passed
+1 compile 272 trunk passed
+1 checkstyle 71 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 809 branch has no errors when building and testing our client artifacts.
+1 javadoc 153 trunk passed
0 spotbugs 325 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 521 trunk passed
-0 patch 377 Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
0 mvndep 25 Maven dependency ordering for patch
+1 mvninstall 466 the patch passed
+1 compile 285 the patch passed
+1 cc 285 the patch passed
+1 javac 285 the patch passed
+1 checkstyle 83 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 622 patch has no errors when building and testing our client artifacts.
+1 javadoc 158 the patch passed
+1 findbugs 569 the patch passed
_ Other Tests _
-1 unit 165 hadoop-hdds in the patch failed.
-1 unit 1698 hadoop-ozone in the patch failed.
+1 asflicense 46 The patch does not generate ASF License warnings.
6737
Reason Tests
Failed junit tests hadoop.ozone.container.common.impl.TestHddsDispatcher
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneRpcClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-920/5/artifact/out/Dockerfile
GITHUB PR #920
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 1e7471d9527b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / fcfe7a3
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/5/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-920/5/testReport/
Max. process+thread count 4149 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/dist U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-920/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 501 trunk passed
+1 compile 300 trunk passed
+1 checkstyle 89 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 892 branch has no errors when building and testing our client artifacts.
+1 javadoc 173 trunk passed
0 spotbugs 331 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 519 trunk passed
-0 patch 387 Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
0 mvndep 19 Maven dependency ordering for patch
+1 mvninstall 468 the patch passed
+1 compile 295 the patch passed
+1 cc 295 the patch passed
+1 javac 295 the patch passed
+1 checkstyle 95 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 702 patch has no errors when building and testing our client artifacts.
+1 javadoc 180 the patch passed
+1 findbugs 537 the patch passed
_ Other Tests _
-1 unit 158 hadoop-hdds in the patch failed.
-1 unit 1192 hadoop-ozone in the patch failed.
+1 asflicense 41 The patch does not generate ASF License warnings.
6404
Reason Tests
Failed junit tests hadoop.ozone.container.common.impl.TestHddsDispatcher
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-920/7/artifact/out/Dockerfile
GITHUB PR #920
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux fd2787f4899d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9191e08
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/7/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-920/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-920/7/testReport/
Max. process+thread count 4599 (vs. ulimit of 5500)
modules C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/dist U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-920/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao xiaoyuyao merged commit 3b31694 into apache:trunk Jun 12, 2019
bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants