-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDDS-1545. Cli to add,remove,get and delete acls for Ozone objects. Contributed by Ajay Kumar. #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
…ontributed by Ajay Kumar.
...n/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
Outdated
Show resolved
Hide resolved
|
|
||
| Test Bucket Acls | ||
| [arguments] ${protocol} ${server} ${volume} | ||
| ${result} = Execute ozone sh volume getacl ${protocol}${server}/${volume}/bb1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be ozone sh bucket
|
|
||
| Test key Acls | ||
| [arguments] ${protocol} ${server} ${volume} | ||
| ${result} = Execute ozone sh volume getacl ${protocol}${server}/${volume}/bb1/key1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be ozone sh key
...ration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
Show resolved
Hide resolved
...one-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
Show resolved
Hide resolved
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/AddAclKeyHandler.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/OzoneAclConfig.java
Show resolved
Hide resolved
|
|
||
| @CommandLine.Option(names = {"--acl", "-a"}, | ||
| required = true, | ||
| description = "new acl." + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acl to be removed. instead of new acl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| OzoneAcl.parseAcl(acl)); | ||
|
|
||
| System.out.printf("%s%n", JsonUtils.toJsonStringWithDefaultPrettyPrinter( | ||
| JsonUtils.toJsonString("Acl set successfully: " + result))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed instead of set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| */ | ||
| @Override | ||
| public Void call() throws Exception { | ||
| Objects.requireNonNull(acls, "New acls to be added not specified."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acls to be set not specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| import static org.apache.hadoop.ozone.security.acl.OzoneObj.StoreType.OZONE; | ||
|
|
||
| /** | ||
| * Executes Info bucket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Executes Info bucket" does not match the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| import static org.apache.hadoop.ozone.security.acl.OzoneObj.StoreType.OZONE; | ||
|
|
||
| /** | ||
| * Executes Info bucket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/SetAclKeyHandler.java
Show resolved
Hide resolved
xiaoyuyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good to me. Just a few minor comments.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…ontributed by Ajay Kumar. (apache#920)
No description provided.