Skip to content

Conversation

@ajayydv
Copy link
Contributor

@ajayydv ajayydv commented May 20, 2019

(cherry picked from commit 7254bf0)

…. Contributed by Ajay Kumar.

(cherry picked from commit 7254bf0)
@ajayydv ajayydv added the ozone label May 20, 2019
@ajayydv ajayydv requested review from anuengineer and xiaoyuyao May 20, 2019 16:36
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
0 mvndep 62 Maven dependency ordering for branch
+1 mvninstall 395 trunk passed
+1 compile 202 trunk passed
+1 checkstyle 53 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 823 branch has no errors when building and testing our client artifacts.
+1 javadoc 122 trunk passed
0 spotbugs 235 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 422 trunk passed
_ Patch Compile Tests _
0 mvndep 25 Maven dependency ordering for patch
+1 mvninstall 377 the patch passed
+1 compile 195 the patch passed
+1 javac 195 the patch passed
-0 checkstyle 23 hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 604 patch has no errors when building and testing our client artifacts.
+1 javadoc 116 the patch passed
+1 findbugs 422 the patch passed
_ Other Tests _
-1 unit 137 hadoop-hdds in the patch failed.
-1 unit 1239 hadoop-ozone in the patch failed.
+1 asflicense 41 The patch does not generate ASF License warnings.
5446
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-834/1/artifact/out/Dockerfile
GITHUB PR #834
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 03cf50d376b3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 24c53e0
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-834/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-834/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-834/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-834/1/testReport/
Max. process+thread count 4278 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-834/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@ajayydv ajayydv force-pushed the HDDS-1065 branch 2 times, most recently from 1413725 to ebc8011 Compare May 21, 2019 02:03
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
0 mvndep 65 Maven dependency ordering for branch
+1 mvninstall 533 trunk passed
+1 compile 267 trunk passed
+1 checkstyle 65 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 817 branch has no errors when building and testing our client artifacts.
+1 javadoc 141 trunk passed
0 spotbugs 308 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 507 trunk passed
_ Patch Compile Tests _
0 mvndep 27 Maven dependency ordering for patch
+1 mvninstall 484 the patch passed
+1 compile 268 the patch passed
+1 cc 268 the patch passed
+1 javac 268 the patch passed
+1 checkstyle 68 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 608 patch has no errors when building and testing our client artifacts.
+1 javadoc 135 the patch passed
+1 findbugs 479 the patch passed
_ Other Tests _
-1 unit 144 hadoop-hdds in the patch failed.
-1 unit 1236 hadoop-ozone in the patch failed.
+1 asflicense 42 The patch does not generate ASF License warnings.
6051
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.client.rpc.TestCommitWatcher
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-834/3/artifact/out/Dockerfile
GITHUB PR #834
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux 9c5dc63198a5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1cb2eb0
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-834/3/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-834/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-834/3/testReport/
Max. process+thread count 4975 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-834/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
0 mvndep 61 Maven dependency ordering for branch
+1 mvninstall 571 trunk passed
+1 compile 276 trunk passed
+1 checkstyle 73 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 846 branch has no errors when building and testing our client artifacts.
+1 javadoc 136 trunk passed
0 spotbugs 306 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 507 trunk passed
_ Patch Compile Tests _
0 mvndep 31 Maven dependency ordering for patch
+1 mvninstall 506 the patch passed
+1 compile 278 the patch passed
+1 cc 278 the patch passed
+1 javac 278 the patch passed
+1 checkstyle 77 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 655 patch has no errors when building and testing our client artifacts.
+1 javadoc 145 the patch passed
+1 findbugs 531 the patch passed
_ Other Tests _
-1 unit 149 hadoop-hdds in the patch failed.
-1 unit 926 hadoop-ozone in the patch failed.
+1 asflicense 58 The patch does not generate ASF License warnings.
6018
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-834/4/artifact/out/Dockerfile
GITHUB PR #834
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname Linux b21d89766c96 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1cb2eb0
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-834/4/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-834/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-834/4/testReport/
Max. process+thread count 5404 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-834/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao
Copy link
Contributor

+1. Thanks @ajayydv for the contribution.

@xiaoyuyao xiaoyuyao merged commit 9c61494 into apache:trunk May 22, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
…stination in the same application

While parsing queries in an application, with in SamzaSqlApplicationConfig, we collect all input sources and output sources from all queries and create descriptors for input sources first followed by output sources. But there could be only one table descriptor instance per table. Writable table is a readable table but vice versa is not true. If we go through input sources, we will end up creating readable table descriptor and would not be able to create writable table descriptor again when we go through output sources (the code will be ugly if we have to achieve this). There are couple of ways to solve this:
- Always make a table readable and writable
- Go through output sources first followed by input sources.

Choosing option 2 as making a table always read-writable does not make sense.

Author: Aditya Toomula <[email protected]>

Reviewers: Srinivasulu Punuru <[email protected]>

Closes apache#834 from atoomula/table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants