Balancer is running when datanode is down , will throw NullPointerException

Author: [email protected]

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java

@@ -286,21 +286,22 @@ private boolean chooseProxySource() {
       // if node group is supported, first try add nodes in the same node group
       if (cluster.isNodeGroupAware()) {
         for (StorageGroup loc : reportedBlock.getLocations()) {
-          if (cluster.isOnSameNodeGroup(loc.getDatanodeInfo(), targetDN)
+            //loc may throw NullPointerException
+          if (loc!=null && cluster.isOnSameNodeGroup(loc.getDatanodeInfo(), targetDN)
               && addTo(loc)) {
             return true;
           }
         }
       }
       // check if there is replica which is on the same rack with the target
       for (StorageGroup loc : reportedBlock.getLocations()) {
-        if (cluster.isOnSameRack(loc.getDatanodeInfo(), targetDN) && addTo(loc)) {
+        if (loc!=null && cluster.isOnSameRack(loc.getDatanodeInfo(), targetDN) && addTo(loc)) {
           return true;
         }
       }
       // find out a non-busy replica
       for (StorageGroup loc : reportedBlock.getLocations()) {
-        if (addTo(loc)) {
+        if (loc!=null && addTo(loc)) {
           return true;
         }
       }