Using waitFor in UT to avoid infinite loop

Minni Mittal · Minni Mittal · commit 5cc0337e345f · 2022-01-11T20:23:29.000+05:30
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestAllocateLatenciesMetrics.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestAllocateLatenciesMetrics.java
@@ -147,8 +147,8 @@ public void testGuaranteedLatenciesMetrics() throws Exception {
         return true;
       } catch (Exception e) {
         LOG.error("Error in allocating container " + e);
+        return false;
       }
-      return false;
     }, 100, 2000);
 
     Container container = allocatedContainers.get(0);

Original file line number	Diff line number	Diff line change
`@@ -147,8 +147,8 @@ public void testGuaranteedLatenciesMetrics() throws Exception {`
`147`	`147`	`return true;`
`148`	`148`	`} catch (Exception e) {`
`149`	`149`	`LOG.error("Error in allocating container " + e);`
	`150`	`+ return false;`
`150`	`151`	`}`
`151`		`- return false;`
`152`	`152`	`}, 100, 2000);`
`153`	`153`
`154`	`154`	`Container container = allocatedContainers.get(0);`