fixing checkstyle issues

Author: omalley

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BufferedFSInputStream.java

@@ -23,7 +23,6 @@
 import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.util.List;
-import java.util.concurrent.CompletableFuture;
 import java.util.function.IntFunction;
 
 import org.apache.hadoop.classification.InterfaceAudience;

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java

@@ -525,7 +525,7 @@ private static class ChecksumFSOutputSummer extends FSOutputSummer {
     private static final float CHKSUM_AS_FRACTION = 0.01f;
     private boolean isClosed = false;
 
-    public ChecksumFSOutputSummer(ChecksumFileSystem fs,
+    ChecksumFSOutputSummer(ChecksumFileSystem fs,
                           Path file,
                           boolean overwrite,
                           int bufferSize,

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileRange.java

@@ -27,7 +27,7 @@
  */
 public interface FileRange {
   /**
-   * Get the starting offset of the range
+   * Get the starting offset of the range.
    * @return the byte offset of the start
    */
   long getOffset();

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/AsyncReaderUtils.java

@@ -73,9 +73,10 @@ public static void readAsync(PositionedReadable stream,
    * @param allocate the function to allocate ByteBuffers
    * @return the CompletableFuture that contains the read data
    */
-  public static CompletableFuture<ByteBuffer> readRangeFrom(PositionedReadable stream,
-                                                            FileRange range,
-                                                            IntFunction<ByteBuffer> allocate) {
+  public static
+  CompletableFuture<ByteBuffer> readRangeFrom(PositionedReadable stream,
+                                              FileRange range,
+                                              IntFunction<ByteBuffer> allocate){
     CompletableFuture<ByteBuffer> result = new CompletableFuture<>();
     try {
       ByteBuffer buffer = allocate.apply(range.getLength());
@@ -104,7 +105,8 @@ public static CompletableFuture<ByteBuffer> readRangeFrom(PositionedReadable str
   }
 
   /**
-   * Is the given input list:
+   * Is the given input list already in the desired order?
+   * In particular, does it meet these requirements:
    * <ul>
    *   <li>already sorted by offset</li>
    *   <li>each range is more than minimumSeek apart</li>
@@ -158,7 +160,8 @@ public static long roundUp(long offset, int chunkSize) {
    *   <li>Upper layers want to pass down logical file ranges.</li>
    *   <li>Fewer reads have better performance.</li>
    *   <li>Applications want callbacks as ranges are read.</li>
-   *   <li>Some file systems want to round ranges to be at checksum boundaries.</li>
+   *   <li>Some file systems want to round ranges to be at checksum boundaries.
+   *   </li>
    * </ul>
    *
    * @param input the list of input ranges
@@ -167,10 +170,11 @@ public static long roundUp(long offset, int chunkSize) {
    * @param maxSize the largest combined file range in bytes
    * @return the list of sorted CombinedFileRanges that cover the input
    */
-  public static List<CombinedFileRange> sortAndMergeRanges(List<? extends FileRange> input,
-                                                           int chunkSize,
-                                                           int minimumSeek,
-                                                           int maxSize) {
+  public static
+  List<CombinedFileRange> sortAndMergeRanges(List<? extends FileRange> input,
+                                             int chunkSize,
+                                             int minimumSeek,
+                                             int maxSize) {
     // sort the ranges by offset
     FileRange[] ranges = input.toArray(new FileRange[0]);
     Arrays.sort(ranges, Comparator.comparingLong(FileRange::getOffset));
@@ -180,8 +184,10 @@ public static List<CombinedFileRange> sortAndMergeRanges(List<? extends FileRang
     // now merge together the ones that merge
     for(FileRange range: ranges) {
       long start = roundDown(range.getOffset(), chunkSize);
-      long end = roundUp(range.getOffset() + range.getLength(), chunkSize);
-      if (current == null || !current.merge(start, end, range, minimumSeek, maxSize)) {
+      long end = roundUp(range.getOffset() + range.getLength(),
+          chunkSize);
+      if (current == null ||
+          !current.merge(start, end, range, minimumSeek, maxSize)) {
         current = new CombinedFileRange(start, end, range);
         result.add(current);
       }