Make it easier to register configuration extension ... #9781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... options closes apache#9529
milenkovicm
commented
Mar 24, 2024
| } | ||
|
|
||
| /// Insert new [ConfigExtension] | ||
| pub fn with_option_extension<T: ConfigExtension>(mut self, extension: T) -> Self { |
Contributor
Author
There was a problem hiding this comment.
we have discussed with_extension_options as the method name, but it make more sense to me to name it like this, not to be confused with with_extension
Contributor
There was a problem hiding this comment.
Yeah I agree this is a reasonable name, even though it still a bit awkward
Contributor
Author
There was a problem hiding this comment.
I'm horrible with naming things 😀 open to suggestions
Contributor
There was a problem hiding this comment.
Yeah, if I had a better alternative I would give it.
alamb
approved these changes
Mar 24, 2024
| } | ||
|
|
||
| /// Insert new [ConfigExtension] | ||
| pub fn with_option_extension<T: ConfigExtension>(mut self, extension: T) -> Self { |
Contributor
There was a problem hiding this comment.
Yeah I agree this is a reasonable name, even though it still a bit awkward
Contributor
|
Thanks again @milenkovicm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... options
closes #9529
Which issue does this PR close?
Closes #9529.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?