Impl gather_filters_for_pushdown for CoalescePartitionsExec
#18046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
approved these changes
Oct 14, 2025
Contributor
adriangb
left a comment
adriangb
left a comment
There was a problem hiding this comment.
Could you add a test (via SLT or unit) that shows that a plan with a CoalesceBatchesExec can support dynamic filter pushdown?
Member
Author
Sure |
xudong963
force-pushed
the
impl_pushdown
branch
from
e333ac7 to
6cdc4e2
Compare
xudong963
commented
Oct 14, 2025
| Ok: | ||
| - SortExec: TopK(fetch=1), expr=[b@1 DESC NULLS LAST], preserve_partitioning=[false] | ||
| - CoalesceBatchesExec: target_batch_size=1024 | ||
| - DataSourceExec: file_groups={1 group: [[test.parquet]]}, projection=[a, b, c], file_type=test, pushdown_supported=true, predicate=DynamicFilter [ empty ] |
Member
Author
There was a problem hiding this comment.
I added a test for CoalesceBatchesExec meanwhile
The key change: predicate=DynamicFilter [ empty ]
xudong963
commented
Oct 14, 2025
| Ok: | ||
| - SortExec: TopK(fetch=1), expr=[b@1 DESC NULLS LAST], preserve_partitioning=[false] | ||
| - CoalescePartitionsExec | ||
| - DataSourceExec: file_groups={2 groups: [[test1.parquet], [test2.parquet]]}, projection=[a, b, c], file_type=test, pushdown_supported=true, predicate=DynamicFilter [ empty ] |
Member
Author
There was a problem hiding this comment.
The key change: predicate=DynamicFilter [ empty ]
xudong963
added a commit
to massive-com/arrow-datafusion
that referenced
this pull request
Oct 14, 2025
…he#18046) * Impl gather_filters_for_pushdown for CoalescePartitionsExec * add tests
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…he#18046) * Impl gather_filters_for_pushdown for CoalescePartitionsExec * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I found
CoalescePartitionsExecdoesn't implementgather_filters_for_pushdown, which means it'll block dynamic filter pushdown. I don't find a reason to forbid it. (Correct me if I misunderstood)What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?