Code review fixes

Author: yoavcloud

src/ast/helpers/key_value_options.rs

@@ -39,13 +39,6 @@ pub struct KeyValueOptions {
     pub delimiter: KeyValueOptionsDelimiter,
 }
 
-impl KeyValueOptions {
-    /// Returns true iff the options list is empty
-    pub fn is_empty(&self) -> bool {
-        self.options.is_empty()
-    }
-}
-
 #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]

src/ast/mod.rs

@@ -10739,7 +10739,7 @@ impl fmt::Display for AlterUser {
         if let Some(policy_kind) = &self.unset_policy {
             write!(f, " UNSET {policy_kind} POLICY")?;
         }
-        if !self.set_tag.is_empty() {
+        if !self.set_tag.options.is_empty() {
             write!(f, " SET TAG {}", self.set_tag)?;
         }
         if !self.unset_tag.is_empty() {

src/parser/mod.rs

@@ -17562,20 +17562,20 @@ impl<'a> Parser<'a> {
                 // Can be a list of values or a list of key value properties.
                 // Try to parse a list of values and if that fails, try to parse
                 // a list of key-value properties.
-                match self.try_parse(|parser| {
+                match self.maybe_parse(|parser| {
                     parser.expect_token(&Token::LParen)?;
                     let values = parser.parse_comma_separated0(|p| p.parse_value(), Token::RParen);
                     parser.expect_token(&Token::RParen)?;
                     values
-                }) {
-                    Ok(values) => {
+                })? {
+                    Some(values) => {
                         let values = values.into_iter().map(|v| v.value).collect();
                         Ok(KeyValueOption {
                             option_name: key.value.clone(),
                             option_value: KeyValueOptionKind::Multi(values),
                         })
                     }
-                    _ => Ok(KeyValueOption {
+                    None => Ok(KeyValueOption {
                         option_name: key.value.clone(),
                         option_value: KeyValueOptionKind::KeyValueOptions(Box::new(
                             self.parse_key_value_options(true, &[])?,