`DateAdd` / `DateSub` do not perform overflow checks in release builds

[andygrove]

Describe the bug

If I build the native library with --release, then I see a test failure. I would not expect this to happen.

- date_add with int scalars (5 seconds, 994 milliseconds)
- date_add with scalar overflow *** FAILED *** (286 milliseconds)
  "Error while decoding: java.lang.ArithmeticException: integer overflow
  createexternalrow(staticinvoke(class org.apache.spark.sql.catalyst.util.DateTimeUtils$, ObjectType(class java.sql.Date), toJavaDate, input[0, date, true], true, false, true), StructField(date_add(_20, 2147483647),DateType,true))." did not contain "attempt to add with overflow" (CometExpressionSuite.scala:255)

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

[andygrove]

The root cause is that the implementation of SparkDateAdd in datafusion-spark is not using checked arithmetic, so only catches overflows in debug builds but not in release builds.

apache/datafusion#17987