Simplify PageEncodingStats

Author: wesm

cpp/src/parquet/metadata.cc

@@ -214,13 +214,10 @@ class ColumnChunkMetaData::ColumnChunkMetaDataImpl {
     for (auto encoding : column_metadata_->encodings) {
       encodings_.push_back(FromThrift(encoding));
     }
-    auto fromthrift = [](format::PageEncodingStats page_encoding_stats) {
-      return parquet::PageEncodingStats(FromThrift(page_encoding_stats.page_type),
-                                        FromThrift(page_encoding_stats.encoding),
-                                        page_encoding_stats.count);
-    };
     for (auto encoding_stats : column_metadata_->encoding_stats) {
-      encoding_stats_.push_back(fromthrift(encoding_stats));
+      encoding_stats_.push_back({FromThrift(encoding_stats.page_type),
+                                 FromThrift(encoding_stats.encoding),
+                                 encoding_stats.count});
     }
     possible_stats_ = nullptr;
   }

cpp/src/parquet/types.cc

@@ -335,24 +335,6 @@ SortOrder::type GetSortOrder(const std::shared_ptr<const LogicalType>& logical_t
 ColumnOrder ColumnOrder::undefined_ = ColumnOrder(ColumnOrder::UNDEFINED);
 ColumnOrder ColumnOrder::type_defined_ = ColumnOrder(ColumnOrder::TYPE_DEFINED_ORDER);
 
-void PageEncodingStats::set_page_type(const PageType::type val) { this->page_type = val; }
-
-void PageEncodingStats::set_encoding(const Encoding::type val) { this->encoding = val; }
-
-void PageEncodingStats::set_count(const int32_t val) { this->count = val; }
-
-PageEncodingStats::PageEncodingStats(const PageEncodingStats& obj) {
-  page_type = obj.page_type;
-  encoding = obj.encoding;
-  count = obj.count;
-}
-PageEncodingStats& PageEncodingStats::operator=(const PageEncodingStats& obj) {
-  page_type = obj.page_type;
-  encoding = obj.encoding;
-  count = obj.count;
-  return *this;
-}
-
 // Static methods for LogicalType class
 
 std::shared_ptr<const LogicalType> LogicalType::FromConvertedType(

cpp/src/parquet/types.h

@@ -503,34 +503,10 @@ class ColumnOrder {
 };
 
 // parquet::PageEncodingStats
-class PARQUET_EXPORT PageEncodingStats {
- public:
-  PageEncodingStats(const PageEncodingStats&);
-  PageEncodingStats(PageEncodingStats&&) = default;
-  PageEncodingStats& operator=(const PageEncodingStats&);
-  PageEncodingStats& operator=(PageEncodingStats&&) = default;
-  PageEncodingStats()
-      : page_type((PageType::type)0), encoding((Encoding::type)0), count(0) {}
-  PageEncodingStats(PageType::type page_type_, Encoding::type encoding_, int32_t count_)
-      : page_type((page_type_)), encoding(encoding_), count(count_) {}
-
+struct PageEncodingStats {
   PageType::type page_type;
   Encoding::type encoding;
   int32_t count;
-
-  void set_page_type(const PageType::type val);
-
-  void set_encoding(const Encoding::type val);
-
-  void set_count(const int32_t val);
-
-  bool operator==(const PageEncodingStats& rhs) const {
-    if (!(page_type == rhs.page_type)) return false;
-    if (!(encoding == rhs.encoding)) return false;
-    if (!(count == rhs.count)) return false;
-    return true;
-  }
-  bool operator!=(const PageEncodingStats& rhs) const { return !(*this == rhs); }
 };
 
 // ----------------------------------------------------------------------