fix: remove eslint-plugin-import-x

Consider we don't really use a lot feature from import-x, while it's rather heavy and recently introduced some binary package. I think it's better to avoid using it and keep this config lightweight and more portable.

- `import/consistent-type-specifier-style` -> `ts/consistent-type-imports`
- `import/no-duplicates` -> `antfu/import-dedupe`
- `import/newline-after-import` -> `style/padding-line-between-statements`

for the other rules, I found their are not always strictly necessary. I am trying to remove them and see how it would affect the DX, and might bring back some of them if needed.

Author: antfu

README.md

@@ -384,7 +384,6 @@ Since flat config requires us to explicitly provide the plugin names (instead of
 
 | New Prefix | Original Prefix        | Source Plugin                                                                              |
 | ---------- | ---------------------- | ------------------------------------------------------------------------------------------ |
-| `import/*` | `import-x/*`           | [eslint-plugin-import-x](https://github.com/un-es/eslint-plugin-import-x)                  |
 | `node/*`   | `n/*`                  | [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n)                     |
 | `yaml/*`   | `yml/*`                | [eslint-plugin-yml](https://github.com/ota-meshi/eslint-plugin-yml)                        |
 | `ts/*`     | `@typescript-eslint/*` | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) |

package.json

@@ -119,7 +119,6 @@
     "eslint-merge-processors": "catalog:prod",
     "eslint-plugin-antfu": "catalog:prod",
     "eslint-plugin-command": "catalog:prod",
-    "eslint-plugin-import-x": "catalog:prod",
     "eslint-plugin-jsdoc": "catalog:prod",
     "eslint-plugin-jsonc": "catalog:prod",
     "eslint-plugin-n": "catalog:prod",

pnpm-lock.yaml

@@ -56,7 +56,6 @@ catalogs:
     eslint-merge-processors: ^2.0.0
     eslint-plugin-antfu: ^3.1.1
     eslint-plugin-command: ^3.2.1
-    eslint-plugin-import-x: ^4.15.1
     eslint-plugin-jsdoc: ^50.7.1
     eslint-plugin-jsonc: ^2.20.1
     eslint-plugin-n: ^17.19.0

pnpm-workspace.yaml

@@ -1,37 +1,18 @@
 import type { OptionsStylistic, TypedFlatConfigItem } from '../types'
 
-import { pluginAntfu, pluginImport } from '../plugins'
-
-export async function imports(options: OptionsStylistic = {}): Promise<TypedFlatConfigItem[]> {
-  const {
-    stylistic = true,
-  } = options
+import { pluginAntfu } from '../plugins'
 
+export async function imports(_options: OptionsStylistic = {}): Promise<TypedFlatConfigItem[]> {
   return [
     {
       name: 'antfu/imports/rules',
       plugins: {
         antfu: pluginAntfu,
-        import: pluginImport,
       },
       rules: {
         'antfu/import-dedupe': 'error',
         'antfu/no-import-dist': 'error',
         'antfu/no-import-node-modules-by-path': 'error',
-
-        'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
-        'import/first': 'error',
-        'import/no-duplicates': 'error',
-        'import/no-mutable-exports': 'error',
-        'import/no-named-default': 'error',
-        'import/no-self-import': 'error',
-        'import/no-webpack-loader-syntax': 'error',
-
-        ...stylistic
-          ? {
-              'import/newline-after-import': ['error', { count: 1 }],
-            }
-          : {},
       },
     },
   ]

src/configs/imports.ts

@@ -1,5 +1,4 @@
 import type { OptionsOverrides, StylisticConfig, TypedFlatConfigItem } from '../types'
-
 import { pluginAntfu } from '../plugins'
 import { interopDefault } from '../utils'
 
@@ -64,6 +63,11 @@ export async function stylistic(
         ),
 
         'style/generator-star-spacing': ['error', { after: true, before: false }],
+        'style/padding-line-between-statements': [
+          'error',
+          { blankLine: 'always', next: '*', prev: 'import' },
+          { blankLine: 'any', next: 'import', prev: 'import' },
+        ],
         'style/yield-star-spacing': ['error', { after: true, before: false }],
 
         ...overrides,

src/configs/stylistic.ts

@@ -62,7 +62,6 @@ export const defaultPluginRenaming = {
 
   '@stylistic': 'style',
   '@typescript-eslint': 'ts',
-  'import-x': 'import',
   'n': 'node',
   'vitest': 'test',
   'yml': 'yaml',

src/factory.ts

@@ -3,7 +3,6 @@
 
 export { default as pluginComments } from '@eslint-community/eslint-plugin-eslint-comments'
 export { default as pluginAntfu } from 'eslint-plugin-antfu'
-export * as pluginImport from 'eslint-plugin-import-x'
 export { default as pluginNode } from 'eslint-plugin-n'
 export { default as pluginPerfectionist } from 'eslint-plugin-perfectionist'
 export { default as pluginUnicorn } from 'eslint-plugin-unicorn'