feat: Adapt to ansys-visualizer #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…s-geometry into feat/common-plotter
Contributor
Author
|
Self reminder: Pyansys visualizer needs to be public before merging this |
Member
|
@AlejandroFernandezLuces - we need to get this working again |
…s-geometry into feat/common-plotter
…s-geometry into feat/common-plotter
…s-geometry into feat/common-plotter
RobPasMue
reviewed
May 27, 2024
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Overall LGTM! Just two small comments before approving
RobPasMue
previously approved these changes
May 28, 2024
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Some minor comments - otherwise LGTM
RobPasMue
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts some common code from the plotter that can be reused in other projects. Extracted code goes to https://github.com/ansys-internal/pyansys-visualizer
Missing: