From ed4dd61ef7186df86eed80c5f212c0e054c035f7 Mon Sep 17 00:00:00 2001 From: Umut Soysal Date: Tue, 15 Jul 2025 16:20:43 -0500 Subject: [PATCH 1/6] activate unit tests. --- src/ansys/geometry/core/__init__.py | 2 +- src/ansys/geometry/core/tools/problem_areas.py | 1 + tests/integration/test_repair_tools.py | 10 ++++------ 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/ansys/geometry/core/__init__.py b/src/ansys/geometry/core/__init__.py index 1b1608da6f..3dfacfec4c 100644 --- a/src/ansys/geometry/core/__init__.py +++ b/src/ansys/geometry/core/__init__.py @@ -71,5 +71,5 @@ DOCUMENTATION_BUILD: bool = os.environ.get("PYANSYS_GEOMETRY_DOC_BUILD", "false").lower() == "true" """Global flag for the documentation to use the proper PyVista Jupyter backend.""" -USE_TRACKER_TO_UPDATE_DESIGN: bool = False +USE_TRACKER_TO_UPDATE_DESIGN: bool = True """Global constant for checking whether to use the tracker to update designs.""" diff --git a/src/ansys/geometry/core/tools/problem_areas.py b/src/ansys/geometry/core/tools/problem_areas.py index 53326adabb..cac2d552c5 100644 --- a/src/ansys/geometry/core/tools/problem_areas.py +++ b/src/ansys/geometry/core/tools/problem_areas.py @@ -111,6 +111,7 @@ def serialize_body(body): }, "master_id": body.master_id, "parent_id": body.parent_id, + "is_surface": body.is_surface, } def serialize_entity_identifier(entity): diff --git a/tests/integration/test_repair_tools.py b/tests/integration/test_repair_tools.py index 1bea52df71..c02d5b54ba 100644 --- a/tests/integration/test_repair_tools.py +++ b/tests/integration/test_repair_tools.py @@ -403,10 +403,9 @@ def test_find_and_fix_missing_faces(modeler: Modeler): for face in missing_faces: face.fix() - # TODO : Add surface body check from backend. Issue is being tracked in #2031. - # assert not design.bodies[0].is_surface - # for comp in design.components: - # assert not comp.bodies[0].is_surface + assert not design.bodies[0].is_surface + for comp in design.components: + assert not comp.bodies[0].is_surface def test_find_and_fix_missing_faces_angle_distance(modeler: Modeler): @@ -458,8 +457,7 @@ def test_find_and_stitch_and_missing_faces(modeler: Modeler): for i in stitch_faces: i.fix() assert len(design.bodies) == 1 - # TODO : Add surface body check from backend. Issue is being tracked in #2031. - # assert design.bodies[0].is_surface + assert design.bodies[0].is_surface missing_faces = modeler.repair_tools.find_missing_faces(design.bodies) for face in missing_faces: face.fix() From 52ad7b2945fe08f33e73bad1a1ad3e81c843877b Mon Sep 17 00:00:00 2001 From: Umut Soysal Date: Tue, 15 Jul 2025 16:22:16 -0500 Subject: [PATCH 2/6] Update repair_tools.py --- src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py b/src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py index 929fdf26d1..0f88173dd0 100644 --- a/src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py +++ b/src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py @@ -620,6 +620,8 @@ def serialize_body(body): }, "master_id": body.master_id, "parent_id": body.parent_id, + "is_surface": body.is_surface, + } def serialize_entity_identifier(entity): From a917f86681c6ab0c06a4291d61bb2839e6f76a43 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 15 Jul 2025 22:01:42 +0000 Subject: [PATCH 3/6] chore: auto fixes from pre-commit hooks --- src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py b/src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py index 0f88173dd0..8c25d5c7f8 100644 --- a/src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py +++ b/src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py @@ -621,7 +621,6 @@ def serialize_body(body): "master_id": body.master_id, "parent_id": body.parent_id, "is_surface": body.is_surface, - } def serialize_entity_identifier(entity): From 1f27c969a64e5a3a00ec36ca8f2f295969d46999 Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Tue, 15 Jul 2025 22:03:06 +0000 Subject: [PATCH 4/6] chore: adding changelog file 2118.added.md [dependabot-skip] --- doc/changelog.d/2118.added.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/2118.added.md diff --git a/doc/changelog.d/2118.added.md b/doc/changelog.d/2118.added.md new file mode 100644 index 0000000000..253ba47cb7 --- /dev/null +++ b/doc/changelog.d/2118.added.md @@ -0,0 +1 @@ +Surface body construct \ No newline at end of file From dc0eff6e57b4aae51d2f0ad3f053432f02808dda Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Tue, 15 Jul 2025 23:13:12 +0000 Subject: [PATCH 5/6] chore: adding changelog file 2118.added.md [dependabot-skip] --- doc/changelog.d/2118.added.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/changelog.d/2118.added.md b/doc/changelog.d/2118.added.md index 253ba47cb7..4c32200adf 100644 --- a/doc/changelog.d/2118.added.md +++ b/doc/changelog.d/2118.added.md @@ -1 +1 @@ -Surface body construct \ No newline at end of file +Surface body unit test fix \ No newline at end of file From 48b4096e7a56587243ce7a8009c1a692d0a9261a Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Wed, 16 Jul 2025 07:48:42 +0200 Subject: [PATCH 6/6] Update src/ansys/geometry/core/__init__.py --- src/ansys/geometry/core/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/geometry/core/__init__.py b/src/ansys/geometry/core/__init__.py index 3dfacfec4c..1b1608da6f 100644 --- a/src/ansys/geometry/core/__init__.py +++ b/src/ansys/geometry/core/__init__.py @@ -71,5 +71,5 @@ DOCUMENTATION_BUILD: bool = os.environ.get("PYANSYS_GEOMETRY_DOC_BUILD", "false").lower() == "true" """Global flag for the documentation to use the proper PyVista Jupyter backend.""" -USE_TRACKER_TO_UPDATE_DESIGN: bool = True +USE_TRACKER_TO_UPDATE_DESIGN: bool = False """Global constant for checking whether to use the tracker to update designs."""