Skip to content

Add SourceLink for source debugging #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

tmilnthorp
Copy link
Collaborator

Adding SourceLink per #532

Adding SourceLink properties and NuGet package
@tmilnthorp
Copy link
Collaborator Author

I'm not 100% sure how this works so dunno how to test it :)

@angularsen
Copy link
Owner

Looks good to me, let's try it!

@angularsen angularsen merged commit c1b8832 into angularsen:master Nov 2, 2018
@angularsen
Copy link
Owner

@tmilnthorp I tried it and can't get it to work in Visual Studio 15.8.7, also running sourcelink test on it reveals some hashes don't match with the github URLs. Will need to look more into it.

Another thing I just realized; I don't think we can use SourceLink after we removed all the generated code - since that source code no longer exists on github. 😞 Maybe we should just stick to symbols nuget packages, which we already have.

@tmilnthorp
Copy link
Collaborator Author

Either that or we can add them back and use the following to clean up the GitHub diffs: https://robots.thoughtbot.com/github-diff-supression

This would be nice too so you don't have to rerun generate every time you check out, switch branches, etc.

angularsen added a commit that referenced this pull request Nov 3, 2018
@angularsen
Copy link
Owner

Let's continue discussion in #439.

@angularsen angularsen changed the title Adding SourceLink properties and NuGet package Add SourceLink for source debugging Nov 4, 2018
@angularsen
Copy link
Owner

This was first reverted, then added back again in #548.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants