-
Notifications
You must be signed in to change notification settings - Fork 394
Add Unit NTU (Turbidity) #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Base dimensions default to 0 so you can simply remove the entire BaseDimensions field.
For example, should we in code type
The reason I ask is that there is more value in adding this quantity if it allows us to convert between units or quantities. |
Turbidity units are very "special" units. They have no conversion between each other, since they base on a calibrated solution liquuid and the equipment used to measure. So depending on how you measure, you use an unit or other. Nowadays the most (or close to only) used method is the one of NTU. So I think just implementing NTU should be ok. This 'old' text explains it.
This unit is often used in water quality measurements. I think the value of the quantity is high (you could use in for example in IOT) and the conversion to ppm adds way more value to it. I work as an engineer in a industrial sensors manufacturer (mainly sensors for food and pharma industry) and for example all our Turbidity sensors use this quantity as output quantity. A lot of other manufacturers use also the same unit. which as said, implies the same type of measurement, in their transmitters. |
Thank you for clarifying.
I am convinced that adding this quantity, even without conversions, does have some value. Mostly because it is so widely used. Please go ahead with creating a pull request, I will be happy to assist if you have any questions. |
Uh oh!
There was an error while loading. Please reload this page.
Is your feature request related to a problem? Please describe.
Add new Quantity => Turbidity + Unit => [NTU]
Describe the solution you'd like
New Quantity Turbidity with unit NTU
Additional context
I already implemented this in my fork and could build/generate custom code without issues.
But since NTU is not an SI unit, I would like to ask if I should make a PR for this, i.e. add the quantity to the library, instead of creating my own copy.
This is the json for
Turbidity
My question is about
BaseDimensions
...Due NTU not being SI, there are noBaseDimensions
for it. Can I do like this and set all to0
?If OK, then I would make a PR for this.
The text was updated successfully, but these errors were encountered: