Skip to content

Add VolumeFlow #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gojanpaolo opened this issue Jan 8, 2018 · 6 comments
Closed

Add VolumeFlow #357

gojanpaolo opened this issue Jan 8, 2018 · 6 comments

Comments

@gojanpaolo
Copy link
Contributor

gojanpaolo commented Jan 8, 2018 •
edited
Loading

Can we add VolumeFlow (Volume/Speed) to the library?
Let me know if we can then I'll submit a PR when I get some free time.
Thank you! :)
@0xferit
Copy link
Contributor

0xferit commented Jan 9, 2018

Do you mean Volume/Time? If yes, we have Flow quantity.

@gojanpaolo
Copy link
Contributor Author

Ahh yes. Volume/Time. Closing this issue. Thank you!

@angularsen
Copy link
Owner

Is VolumeFlow a more accurate naming or is Flow clear enough?

@gojanpaolo
Copy link
Contributor Author

There is MassFlow so I thought the name would be VolumeFlow.

@0xferit
Copy link
Contributor

0xferit commented Jan 10, 2018

@angularsen We use Flow and MassFlow too and at first we were confused too. Perhaps renaming it worth the effort.

@angularsen
Copy link
Owner

Ok then, I propose adding VolumeFlow (copy Flow and rename it) and obsoleting Flow so we can deprecate it. I've created #363 so someone can grab it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@angularsen @0xferit @gojanpaolo