Deprecate more usage of QuantityType (#1019)

Author: tmilnthorp

CodeGen/Generators/UnitsNetGen/QuantityGenerator.cs

@@ -249,7 +249,7 @@ private void GenerateStaticProperties()
         /// <summary>
         ///     The <see cref=""QuantityType"" /> of this quantity.
         /// </summary>
-        [Obsolete(""QuantityType will be removed in the future. Use Info property instead."")]
+        [Obsolete(""QuantityType will be removed in the future. Use the Info property instead."")]
         public static QuantityType QuantityType {{ get; }} = QuantityType.{_quantity.Name};
 
         /// <summary>
@@ -303,7 +303,8 @@ private void GenerateProperties()
         /// <summary>
         ///     The <see cref=""QuantityType"" /> of this quantity.
         /// </summary>
-        public QuantityType Type => {_quantity.Name}.QuantityType;
+        [Obsolete(""QuantityType will be removed in the future. Use the Info property instead."")]
+        public QuantityType Type => QuantityType.{_quantity.Name};
 
         /// <summary>
         ///     The <see cref=""BaseDimensions"" /> of this quantity.

CodeGen/Generators/UnitsNetGen/QuantityTypeGenerator.cs

@@ -16,6 +16,9 @@ public override string Generate()
             Writer.WL(GeneratedFileHeader);
             Writer.WL(@"
 // ReSharper disable once CheckNamespace
+
+using System;
+
 namespace UnitsNet
 {
     /// <summary>
@@ -24,6 +27,7 @@ namespace UnitsNet
     ///     This is useful for populating options in the UI, such as creating a generic conversion
     ///     tool with inputValue, quantityName, fromUnit and toUnit selectors.
     /// </summary>
+    [Obsolete(""QuantityType will be removed in the future. Use the QuantityInfo class instead."")]
     public enum QuantityType
     {
 // Missing XML comment for public type or member

CodeGen/Generators/UnitsNetGen/StaticQuantityGenerator.cs

@@ -43,16 +43,6 @@ public static partial class Quantity
             Writer.WL(@"
         };
 
-        // Used by the QuantityInfo .ctor to map a name to a QuantityType. Will be removed when QuantityType
-        // will be removed.
-        internal static readonly IDictionary<string, QuantityType> QuantityTypeByName = new Dictionary<string, QuantityType>
-        {");
-            foreach (var quantity in _quantities)
-                Writer.WL($@"
-            {{ ""{quantity.Name}"", QuantityType.{quantity.Name} }},");
-            Writer.WL(@"
-        };
-
         /// <summary>
         /// Dynamically constructs a quantity of the given <see cref=""QuantityType""/> with the value in the quantity's base units.
         /// </summary>

CodeGen/Generators/UnitsNetWrcGen/QuantityGenerator.cs

@@ -1,4 +1,4 @@
-// Licensed under MIT No Attribution, see LICENSE file at the root.
+// Licensed under MIT No Attribution, see LICENSE file at the root.
 // Copyright 2013 Andreas Gullberg Larsen ([email protected]). Maintained at https://github.com/angularsen/UnitsNet.
 
 using System;
@@ -194,6 +194,7 @@ private void GenerateStaticProperties()
         /// <summary>
         ///     The <see cref=""QuantityType"" /> of this quantity.
         /// </summary>
+        [Obsolete(""QuantityType will be removed in the future. Use the Info property instead."")]
         public static QuantityType QuantityType {{ get; }} = QuantityType.{_quantity.Name};
 
         /// <summary>
@@ -235,6 +236,7 @@ private void GenerateProperties()
         /// <summary>
         ///     The <see cref=""QuantityType"" /> of this quantity.
         /// </summary>
+        [Obsolete(""QuantityType will be removed in the future. Use the Info property instead."")]
         public QuantityType Type => {_quantity.Name}.QuantityType;
 
         /// <summary>
@@ -585,7 +587,7 @@ public bool Equals({_quantity.Name} other, double tolerance, ComparisonType comp
         /// <returns>A hash code for the current {_quantity.Name}.</returns>
         public override int GetHashCode()
         {{
-            return new {{ QuantityType, Value, Unit }}.GetHashCode();
+            return new {{ Info.Name, Value, Unit }}.GetHashCode();
         }}
 
         #endregion

CodeGen/Generators/UnitsNetWrcGen/QuantityTypeGenerator.cs

@@ -1,4 +1,4 @@
-using CodeGen.JsonTypes;
+using CodeGen.JsonTypes;
 
 namespace CodeGen.Generators.UnitsNetWrcGen
 {
@@ -16,6 +16,9 @@ public override string Generate()
             Writer.WL(GeneratedFileHeader);
             Writer.WL(@"
 // ReSharper disable once CheckNamespace
+
+using System;
+
 namespace UnitsNet
 {
     /// <summary>
@@ -24,6 +27,7 @@ namespace UnitsNet
     ///     This is useful for populating options in the UI, such as creating a generic conversion
     ///     tool with inputValue, quantityName, fromUnit and toUnit selectors.
     /// </summary>
+    [Obsolete(""QuantityType will be removed in the future. Use the QuantityInfo class instead."")]
     public enum QuantityType
     {
         Undefined = 0,");