Skip to content

Commit d469707

Browse files
authored
Remove comment on OverflowException
As per @gojanpaolo 's comment: #389 (comment) This will not throw when converting to double, since double has a big enough range to contain all other numeric types in .NET.
1 parent 5551de2 commit d469707

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

UnitsNet.Serialization.JsonNet/UnitsNetJsonConverter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,6 @@ public override void WriteJson(JsonWriter writer, object obj, JsonSerializer ser
206206

207207
serializer.Serialize(writer, new ValueUnit
208208
{
209-
// This might throw OverflowException for very large values?
210209
// TODO Should we serialize long, decimal and long differently?
211210
Value = Convert.ToDouble(quantityValue),
212211
Unit = quantityUnitName

0 commit comments

Comments
 (0)